Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9829 Main news articles #573

Merged
merged 13 commits into from
Apr 12, 2024
Merged

UHF-9829 Main news articles #573

merged 13 commits into from
Apr 12, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Apr 9, 2024

UHF-9829

Notice! Check and merge the news article PR before merging this one.

What was done

  • Moved the "ordered news" views admin page styles to etusivu-instance.
  • Created the "ordered news articles list" draggable view and added a menu link for it in to the tools menu.
  • Created/Updated translations for the news article promoted field, news articles, front page top news paragraph, ordered news list view and ordered news articles list view.
  • Added "main news articles" block to "frontpage news" view and added "news article" content type to "of interest" view.

How to install

  • Make sure your helfi-etusivu instance is up and running on latest dev branch.
    • git fetch --all && git checkout UHF-9736 && git pull origin UHF-9736
    • make fresh
  • Switch to UHF-9829_main_news_articles branch in etusivu instance and run drush deploy
  • Update the HDBT Admin theme
    • composer require drupal/hdbt_admin:dev-UHF-9829_main_news_articles
  • Run make drush-cim drush-cr

How to test

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well but some issues with the border color on the admin UI still.

public/modules/custom/helfi_etusivu/assets/css/views.css Outdated Show resolved Hide resolved
public/modules/custom/helfi_etusivu/assets/css/views.css Outdated Show resolved Hide resolved
@khalima khalima requested a review from teroelonen April 12, 2024 04:47
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well now and looks good 🦖

khalima added 2 commits April 12, 2024 11:01
…al-helfi-etusivu into UHF-9829_main_news_articles
…al-helfi-etusivu into UHF-9829_main_news_articles
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@khalima khalima merged commit 5f8a014 into UHF-9736 Apr 12, 2024
2 checks passed
@khalima khalima deleted the UHF-9829_main_news_articles branch April 12, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants