Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9738: news article content type #572

Merged
merged 19 commits into from
Apr 11, 2024
Merged

UHF-9738: news article content type #572

merged 19 commits into from
Apr 11, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Apr 8, 2024

UHF-9738

What was done

  • Add news_article content type with required hero.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-9738-news-article
    • composer require drupal/hdbt:dev-UHF-9738
    • composer require drupal/hdbt_admin:dev-UHF-9738-news-article
    • composer require drupal/helfi_platform_config:dev-UHF-9738-news-article
    • make fresh
  • Run make drush-cr

How to test

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

@hyrsky hyrsky force-pushed the UHF-9738-news-article branch from 45e6d5f to 6de2000 Compare April 8, 2024 12:17
@khalima khalima changed the base branch from dev to UHF-9736 April 9, 2024 08:13
@khalima khalima mentioned this pull request Apr 9, 2024
5 tasks
teroelonen and others added 7 commits April 9, 2024 18:15
…y instead of list_value on default view, hide published_at field on default view, hide page-title block on news article content
…Helsinki/drupal-helfi-etusivu into UHF-9738-news-article
… configuration for the hero block on news articles
…or the news article hero block configuration
…Helsinki/drupal-helfi-etusivu into UHF-9738-news-article
@teroelonen teroelonen marked this pull request as ready for review April 10, 2024 13:08
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few English configurations were in Finnish, otherwise this is excellent!

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellance! 🚀

@khalima khalima merged commit 6e45fa8 into UHF-9736 Apr 11, 2024
1 of 2 checks passed
@khalima khalima deleted the UHF-9738-news-article branch April 11, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants