Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10103: Hakuvahti React Frontend. #992

Merged
merged 26 commits into from
May 29, 2024
Merged

UHF-10103: Hakuvahti React Frontend. #992

merged 26 commits into from
May 29, 2024

Conversation

sundflux
Copy link
Contributor

@sundflux sundflux commented May 22, 2024

UHF-10103

React part of Hakuvahti frontend. Hakuvahti is shown on Rekry job search page. If Hakuvahti is not configured (HAKUVAHTI_URL envvar is not set), the form is hidden from search page.

What was done

Adds new form to Rekry job search page to sign up for Hakuvahti subscription with email.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin hakuvahti
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:hakuvahti
  • Run make drush-cr

How to test

  • Check that search page works when Hakuvahti is not configured (no HAKUVAHTI_URL configured).
  • Check that search page works and Hakuvahti subscribe form shows up on search page with HAKUVAHTI_URL configuration

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

City-of-Helsinki/drupal-helfi-rekry#475

@sundflux sundflux requested review from teroelonen and rpnykanen May 22, 2024 11:31
@sundflux sundflux changed the title UHF-9300: Hakuvahti React Frontend. UHF-10103: Hakuvahti React Frontend. May 22, 2024
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 🦖

Copy link

github-actions bot commented May 22, 2024

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/992/html_report/

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be good to go now 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants