Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hakuvahti Drupal Module #475

Merged
merged 84 commits into from
May 29, 2024
Merged

Hakuvahti Drupal Module #475

merged 84 commits into from
May 29, 2024

Conversation

sundflux
Copy link
Contributor

@sundflux sundflux commented May 22, 2024 •
edited by jira bot
Loading

UHF-10103

Adds Drupal module for Hakuvahti integration.

What was done

Adds new backend module to subscribe for Hakuvahti and enables it.

To be used with this PR which includes the React frontend.

  • This thing was fixed

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout hakuvahti
    • make fresh
  • Run make drush-cr
  • Either checkout related PR as theme dir, or wait until it is merged first to main.

How to test

  • Default dev environment includes HAKUVAHTI_URL parameter so the subscription form should show up at search page.
  • Check that translations work with different languages.
  • Install Hakuvahti to test the actual subscribing. Hakuvahti needs at least ATV key from Azure.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

City-of-Helsinki/drupal-hdbt#992

sundflux and others added 30 commits May 7, 2024 07:47
@sundflux
UHF-9287: Frontend module sans React front. Subscribe still bugs for …
2eb2dce 
…some reason
@sundflux
UHF-9287: Not needed
d4b4964
@sundflux
UHF-9287: Correct translation strings
14b7a6f
@sundflux
UHF-9287: Translation stuff, doesn't load for some reason
62ab740
@sundflux
UHF-9287: String fix
49de378
@sundflux
UHF-9287: Hakuvahti url
781a53f
@sundflux
UHF-9287: Cleanups and refactoring
3633039
@sundflux
UHF-9287: Cleanup
8a55597
@sundflux
UHF-9287: Enable extension
a8aac7f
@teroelonen
UHF-9287: Fixed some PHPCS
fb511ae
@sundflux
UHF-9287: Add class+function docblocks
f2897e7
@sundflux
UHF-9287: Fix linter problems
d098675
@sundflux
UHF-9287: Fix linter problems
75dc4e6
@sundflux
UHF-9287: Add note about tokens
cf146dd
@teroelonen
UHF-9287: Styled the search monitor accordion a bit
cff995f
@teroelonen
UHF-9287: Add border above the search monitor
f29a7d2
@teroelonen
UHF-9287: Minor layout adjustments to search monitor
c4bbdfe
@sundflux
UHF-9287: Fix local hakuvahti url
bc97819
@sundflux
UHF-9287: Merge branch 'UHF-9287-hakuvahti-frontend' of https://githu…
4406c28 
…b.com/City-of-Helsinki/drupal-helfi-rekry into UHF-9287-hakuvahti-frontend
@sundflux
UHF-9287: Update env var url, remove useless local one
44214f4
@sundflux
UHF-9287: Hakuvahti url to preflight checks
54b08f0
@teroelonen
UHF-10004: Adjusting translations for the Drupal module
20b1b9c
@teroelonen
UHF-10004: Merge branch 'UHF-9287-hakuvahti-frontend' of github.com:C…
0e00aed 
…ity-of-Helsinki/drupal-helfi-rekry into UHF-10004
@teroelonen
UHF-9287: Add hakuvahti url to compose.yml
a42edea
@teroelonen
UHF-9287: Merge branch 'UHF-9287-hakuvahti-frontend' of github.com:Ci…
1e92fa5 
…ty-of-Helsinki/drupal-helfi-rekry into UHF-9287-hakuvahti-frontend
@teroelonen
UHF-10004: Merge branch 'UHF-9287-hakuvahti-frontend' of github.com:C…
a2d7bf8 
…ity-of-Helsinki/drupal-helfi-rekry into UHF-10004
@teroelonen
UHF-10004: Change the language variable check to the url from session
4a0868d
@teroelonen
UHF-10004: Add Swedish translations
b9d4528
@teroelonen
UHF-10004: Adjust translations a bit
1ba097a
@sundflux
UHF-9287: This fixes missing HAKUVAHTI_URL env variable
afe53ff
teroelonen and others added 26 commits May 23, 2024 12:42
@teroelonen
UHF-10005: Style the hakuvahti notifications
a6366dd
@teroelonen
UHF-10005: Add missing component wrapper to all confirmation messages
d536b07
@teroelonen
UHF-10005: Fix PHPCS
53f2e7e
@sundflux
Merge pull request #472 from City-of-Helsinki/UHF-10080
2033de2 
UHF-10080: added hakuvahti external network for drupal
@sundflux
Merge pull request #476 from City-of-Helsinki/UHF-10005
a8693ce 
UHF-10005: Hakuvahti styling
@sundflux
Merge branch 'hakuvahti' of https://github.com/City-of-Helsinki/drupa…
b81d6ff 
…l-helfi-rekry into hakuvahti
@sundflux
Add new unified controller for confirm + unsubscribe and move layout …
3caa106 
…to twig templates.
@sundflux
Update routing to point to the new module.
58f1a23
@sundflux
Linter fixes
9175b44
@sundflux
Remove old controllers
1763126
@sundflux
Attempt to fix the layout
ab7233e
@sundflux
Try to please sonarcloud
f59e9da
@sundflux
Try to please sonarcloud
ae15e50
@sundflux
Well it doesn't work that way...
abfa7c2
@teroelonen
Adjust templates for hakuvahti confirmation after refactoring changes
0443ee3
@teroelonen
Add missing template for hakuvahti message wrapper
3229b28
@teroelonen
Move all templates under hdbt_subtheme, refactor templates to smaller…
7d18895 
… number
@teroelonen
Wrap the back-link to paragraph tag
f0822af
@teroelonen
Streamline the action wrapper template a bit
daa1f3f
@teroelonen
Change the network name to correct one
0d99f5e
@teroelonen
Merge pull request #479 from City-of-Helsinki/hakuvahti-X-sc_changes
7ce57a3 
Hakuvahti SonarCloud changes.
@sundflux
Merge branch 'hakuvahti' of https://github.com/City-of-Helsinki/drupa…
cdc8028 
…l-helfi-rekry into hakuvahti
@sundflux
Hopefully fix docker connection to HAV
7cd5fe5
@sundflux
Network naming fix
1df6b4b
@sundflux
Network naming fix
e65f59f
@sundflux
Merge pull request #480 from City-of-Helsinki/UHF-X-fixdocker
d54bbb8 
UHF-X: Fix docker connection to HAV
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

teroelonen
teroelonen approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be good to go now 🦖

@sundflux sundflux merged commit c94ff6c into dev May 29, 2024
2 checks passed
@sundflux sundflux deleted the hakuvahti branch May 29, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

@rpnykanen rpnykanen Awaiting requested review from rpnykanen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sundflux @teroelonen @rpnykanen