Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-4905 hdbt documentation #684

Merged
merged 6 commits into from
Jun 8, 2023
Merged

UHF-4905 hdbt documentation #684

merged 6 commits into from
Jun 8, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jun 7, 2023 •
edited
Loading

UHF-4905

What was done

  • Documentation was updated to include more information.

How to test

  • Read the documentation and make sure that its easy to understand and doesn't include mistakes.

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

@teroelonen teroelonen mentioned this pull request Jun 7, 2023
Merged
3 tasks
@teroelonen teroelonen mentioned this pull request Jun 7, 2023
Merged
3 tasks
@teroelonen teroelonen marked this pull request as ready for review June 7, 2023 15:33
Jussiles
Jussiles approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@Jussiles Jussiles left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Added one comment to HDBT admin theme. Same thing could be added to here too.

khalima
khalima approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the documentation is good. However I do suggest few changes.. you can see them in comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@teroelonen teroelonen merged commit 6343e4a into main Jun 8, 2023
@teroelonen teroelonen deleted the UHF-4905_hdbt_documentation branch June 8, 2023 06:52
This was referenced Jun 8, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jussiles Jussiles Jussiles approved these changes

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teroelonen @khalima @Jussiles