Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-4905 hdbt documentation #221

Merged
merged 2 commits into from
Jun 8, 2023
Merged

UHF-4905 hdbt documentation #221

merged 2 commits into from
Jun 8, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jun 7, 2023

UHF-4905

What was done

  • Documentation was updated to include more information.

How to test

  • Read the documentation and make sure that its easy to understand and doesn't include mistakes.

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

Copy link
Contributor

@Jussiles Jussiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me. Added on small comment that could be changed.

README.md Show resolved Hide resolved
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested few changes to HDBT documentation which could be copied here also: City-of-Helsinki/drupal-hdbt#684 (review)
But as in HDBT PR, I do approve these changes as they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants