Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uhf 10078 table scrolling fix #1038

Merged
merged 4 commits into from
Aug 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dist/css/ckeditor.min.css

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/css/styles.min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/js/job-search.min.js

Large diffs are not rendered by default.

8 changes: 7 additions & 1 deletion src/scss/04_elements/_table.scss
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ $table-shadow-mask-width: $table-shadow-width * 2.857; // 40px, 2.857 is the rat

.user-edited-content figure figcaption {
@include font('h4');
background: $table-bg-color;
background: var(--user-edited-content-background-color, #{$table-bg-color});
left: 0;
margin-top: 0;
padding-bottom: $spacing;
Expand All @@ -66,12 +66,18 @@ $table-shadow-mask-width: $table-shadow-width * 2.857; // 40px, 2.857 is the rat
margin-top: $spacing;
}

// wysiwyg editor generates these duplicate figures, so we need to remove the margin from the second figure
.user-edited-content figure > figure {
margin-top: 0;
}

.user-edited-content figure figcaption + table {
margin-top: 0;
}

.user-edited-content figure table {
background: transparent;
box-shadow: 0 0 0 $content-width-max var(--user-edited-content-background-color, #{$table-bg-color}); // This handles the figure background color when narrow table is on grey background.
margin-top: 0;
}

Expand Down
3 changes: 2 additions & 1 deletion src/scss/06_components/paragraphs/_accordion.scss
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,8 @@
}

.accordion-item__content {
background-color: $color-black-5;
--user-edited-content-background-color: #{$color-black-5}; // This allows passing the color to the child figcaption and other possible elements
background-color: var(--user-edited-content-background-color);
}

// Patch Siteimprove false positive color contrast issue to reduce noise
Expand Down
Loading