Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uhf 10078 table scrolling fix #1038

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Uhf 10078 table scrolling fix #1038

merged 4 commits into from
Aug 12, 2024

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Aug 12, 2024 •
edited by jira bot
Loading

UHF-10078

The new figcaption code for scrolling tables did not handle grey accordions properly

image

What was done

  • Grey accordions background was fixed

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-0000_insert_correct_branch
  • Run make drush-cr

How to test

  • Check that scrollable tables work now with grey accordions too
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

teroelonen
teroelonen approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just so cool by the Tapionlinna-wizard 🦖

@Arkkimaagi Arkkimaagi merged commit 15455bd into main Aug 12, 2024
1 of 2 checks passed
@Arkkimaagi Arkkimaagi deleted the UHF-10078_table_scrolling_fix branch August 12, 2024 14:59
This was referenced Aug 13, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkkimaagi @teroelonen