Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rust-bindgen ident issue #2

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Conversation

NgaiJustin
Copy link
Contributor

Currently the btor2tools does not build. It panics with the following error

thread 'main' panicked at '"Btor2Sort_union_(anonymous_at_/.../target/debug/build/btor2tools-sys-54a31d899707ee43/out/btor2tools-src/src/btor2parser/btor2parser_h_139_3)" is not a valid Ident', .../.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.69/src/fallback.rs:817:9

The issue is outlined here. It is resolved in later versions, specifically >=0.62.0

There are many other instances (such as this) of fixes with just bumping the build dependency

@ChristianMoesl
Copy link
Owner

Thanks for the PR! I wasn't able to reproduce that error, when running the CI pipeline: https://github.com/ChristianMoesl/btor2tools-sys/actions/runs/6812725407
So I guess, this problem occurs with a specific version of LLVM!?

Anyway, I think it's a good call to bump the bindgen version anyway, so I'll merge it.

@ChristianMoesl ChristianMoesl merged commit ffa310c into ChristianMoesl:main Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants