thread 'main' panicked at '"__mbstate_t_(anonymous_struct_at_foo_cc_2_3)" is not a valid Ident' #2312

glandium · 2022-10-17T22:46:50Z

This started happening on clang-trunk with llvm/llvm-project@19e984e

Input C/C++ Header

typedef struct {
  struct {};
} __mbstate_t;

Bindgen Invocation

bindgen::Builder::default()
    .header("foo.cc")
    .generate()
    .unwrap()

Actual Results

thread 'main' panicked at '"__mbstate_t_(anonymous_struct_at_foo_cc_2_3)" is not a valid Ident', /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.46/src/fallback.rs:756:9
stack backtrace:
   0: rust_begin_unwind
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/std/src/panicking.rs:584:5
   1: core::panicking::panic_fmt
             at /rustc/a55dd71d5fb0ec5a6a3a9e8c27b2127ba491ce52/library/core/src/panicking.rs:142:14
   2: proc_macro2::fallback::validate_ident
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.46/src/fallback.rs:756:9
   3: proc_macro2::fallback::Ident::_new
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.46/src/fallback.rs:698:9
   4: proc_macro2::fallback::Ident::new
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.46/src/fallback.rs:708:9
   5: proc_macro2::Ident::new
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.46/src/lib.rs:974:21
   6: bindgen::ir::context::BindgenContext::rust_ident_raw
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.60.1/src/ir/context.rs:861:9
   7: bindgen::ir::context::BindgenContext::rust_ident
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.60.1/src/ir/context.rs:853:9
   8: <bindgen::ir::comp::CompInfo as bindgen::codegen::CodeGenerator>::codegen
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.60.1/src/codegen/mod.rs:1786:31
   9: <bindgen::ir::ty::Type as bindgen::codegen::CodeGenerator>::codegen
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.60.1/src/codegen/mod.rs:814:39
  10: <bindgen::ir::item::Item as bindgen::codegen::CodeGenerator>::codegen
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.60.1/src/codegen/mod.rs:500:17
  11: <bindgen::ir::comp::CompInfo as bindgen::codegen::CodeGenerator>::codegen
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.60.1/src/codegen/mod.rs:2115:13
  12: <bindgen::ir::ty::Type as bindgen::codegen::CodeGenerator>::codegen
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.60.1/src/codegen/mod.rs:814:39
  13: <bindgen::ir::item::Item as bindgen::codegen::CodeGenerator>::codegen
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.60.1/src/codegen/mod.rs:500:17
  14: <bindgen::ir::module::Module as bindgen::codegen::CodeGenerator>::codegen::{{closure}}
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.60.1/src/codegen/mod.rs:523:21
  15: <bindgen::ir::module::Module as bindgen::codegen::CodeGenerator>::codegen
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.60.1/src/codegen/mod.rs:553:13
  16: <bindgen::ir::item::Item as bindgen::codegen::CodeGenerator>::codegen
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.60.1/src/codegen/mod.rs:491:17
  17: bindgen::codegen::codegen::{{closure}}
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.60.1/src/codegen/mod.rs:4364:9
  18: bindgen::ir::context::BindgenContext::gen
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.60.1/src/ir/context.rs:1173:19
  19: bindgen::codegen::codegen
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.60.1/src/codegen/mod.rs:4328:5
  20: bindgen::Bindings::generate
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.60.1/src/lib.rs:2438:32
  21: bindgen::Builder::generate
             at /home/glandium/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.60.1/src/lib.rs:1502:9

The text was updated successfully, but these errors were encountered:

emilio · 2022-10-17T23:06:03Z

This is due to this behavior change here, which changes the behavior of libclang:

llvm/llvm-project@19e984e#diff-cde6fae42b53073a85e0901697f60ea80262705f86643b7b27524c7bd24c6f80

It seems they changed an API that was returning an empty string to return a formatted thing that we can't really easily parse or identify as an anonymous struct.

@glandium I think this is worth an upstream bug report, could you do that if you have a build locally? Or do you want me to?

glandium · 2022-10-17T23:50:04Z

Better if you do because I don't really know what bindgen would rather have available.

emilio · 2022-10-18T00:22:36Z

@glandium can you check if e69e0df, or 9763aa5 (on top) pass tests with llvm trunk? I can check tomorrow otherwise.

glandium · 2022-10-18T00:43:19Z

Tests seem to pass, but they also pass with current master...

However, for the testcase, with e69e0df + clang-trunk:

#[repr(C)]
#[derive(Debug, Copy, Clone)]
pub struct __mbstate_t {
    pub _address: u8,
}
#[repr(C)]
#[derive(Debug, Copy, Clone)]
pub struct __mbstate_t__bindgen_ty_1 {
    pub _address: u8,
}

With e69e0df + clang 14:

#[repr(C)]
#[derive(Debug, Copy, Clone)]
pub struct __mbstate_t {
    pub __bindgen_anon_1: __mbstate_t__bindgen_ty_1,
}
#[repr(C)]
#[derive(Debug, Copy, Clone)]
pub struct __mbstate_t__bindgen_ty_1 {
    pub _address: u8,
}

glandium · 2022-10-18T00:55:39Z

Tests seem to pass, but they also pass with current master...

scrap that, I didn't run them correctly. They do fail with master and fail less with your patches, but there are still 39 failing (vs. 87 without the patches), with errors that align with the previous comment.

In trunk, Clang started emitting names like `"(unnamed enum at foo.cpp:4:2)"` for unnamed enums, structs, and unions, while previous versions emitted the empty string. This caused panics. This commit simply rewrites such names back to the empty string so that we stay compatible with both old and new versions of Clang. Closes rust-lang#2312.

pcwalton · 2022-10-21T01:07:27Z

#2316 is a fix.

…y names. In Clang 16, anonymous items may return names like `(anonymous union at ..)` rather than empty names. The right way to detect them is using clang_Cursor_isAnonymous. Fixes rust-lang#2312 Closes rust-lang#2316 Co-Authored-by: Patrick Walton <[email protected]>

…y names. In Clang 16, anonymous items may return names like `(anonymous union at ..)` rather than empty names. The right way to detect them is using clang_Cursor_isAnonymous. Fixes #2312 Closes #2316 Co-Authored-by: Patrick Walton <[email protected]>

…y names. In Clang 16, anonymous items may return names like `(anonymous union at ..)` rather than empty names. The right way to detect them is using clang_Cursor_isAnonymous. Fixes rust-lang#2312 Closes rust-lang#2316 Co-Authored-by: Patrick Walton <[email protected]>

tgross35 · 2022-11-11T08:16:17Z

It looks like #2316 was canceled but #2319 resolved it instead? I am wondering why I am still hitting this issue on 0.61.0

  thread 'main' panicked at '"type-parameter-0-1" is not a valid Ident', /home/default/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.47/src/fallback.rs:756:9
  stack backtrace:
     0: rust_begin_unwind
               at /rustc/a8314ef7d0ec7b75c336af2c9857bfaf43002bfc/library/std/src/panicking.rs:584:5
     1: core::panicking::panic_fmt
               at /rustc/a8314ef7d0ec7b75c336af2c9857bfaf43002bfc/library/core/src/panicking.rs:142:14
     2: proc_macro2::fallback::validate_ident
               at /home/default/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.47/src/fallback.rs:756:9
     3: proc_macro2::fallback::Ident::_new
               at /home/default/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.47/src/fallback.rs:698:9
     4: proc_macro2::fallback::Ident::new
               at /home/default/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.47/src/fallback.rs:708:9
     5: proc_macro2::imp::Ident::new
               at /home/default/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.47/src/wrapper.rs:701:50
     6: proc_macro2::Ident::new
               at /home/default/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-1.0.47/src/lib.rs:974:21
     7: bindgen::ir::context::BindgenContext::rust_ident_raw
               at /home/default/.cargo/registry/src/github.com-1ecc6299db9ec823/bindgen-0.61.0/ir/context.rs:859:9

tgross35 · 2022-11-11T08:18:20Z

Oops, I misread the release log, looks like there actually hasn't been one since the patch.

Please ignore me, hopefully the next release isn't too far

Unable to compile with Guile 3.x due to a clang update, which caused bindgen to break: rust-lang/rust-bindgen#2312 This also updates the bindings to GNU Guile 3.0.9.

Unfortunately, Debian 11 has just too old Rust which prevents us from working on anything not prehistoric. There are couple of issues: 1) It doesn't understand modern Cargo.toml syntax, which causes CI failures: https://gitlab.com/libvirt/libvirt-rust/-/merge_requests/64 2) We currently require bindgen-0.59.2 which doesn't work with LLVM-16 because of: rust-lang/rust-bindgen#2312 The fix is contained in bindgen-0.62.0. While there is some intersect between versions available to Debian 11 version of Rust (0.65.1, 0.64.0, 0.63.0, 0.62.0) neither of them generate code that Debian 11 version of Rust (1.48.0) understands. The bindgen-0.62.0 release notes set the minimal required version of rust to 1.57.0 anyway: https://crates.io/crates/bindgen/0.62.0 We are stuck. And the only way out is just to drop Debian 11 support. Live long my old friend. Signed-off-by: Michal Privoznik <[email protected]>

Unable to compile with Guile 3.x due to a clang update, which caused bindgen to break: rust-lang/rust-bindgen#2312 This also updates the bindings to GNU Guile 3.0.9.

As LLVM-16 is getting more and more popular, we are hitting the following bug when trying to regenerate bindings from libvirt header files: rust-lang/rust-bindgen#2312 Long story short, bindgen is not happy with some value that LLVM-16 returns (LLVM-15 is okay) and panics. While it's sufficient to bump bindgen to 0.62.0 we can go all the way to 0.69.2 which is supposed to work even with LLVM-18: https://github.com/rust-lang/rust-bindgen/blob/main/CHANGELOG.md#0692-2024-01-13 Signed-off-by: Michal Privoznik <[email protected]>

See rust-lang/rust-bindgen#2312

This updates `bindgen` to 0.64, fixing rust-lang/rust-bindgen#2312 (via [`libpg_query-sys`](https://crates.io/crates/libpg_query-sys/0.2.1)) when building from source.

Bump bindgen to support newer clang versions. See rust-lang/rust-bindgen#2312 Also adapt the types referring to a size to usize, otherwise the new bindgen will no longer accept it. Signed-off-by: Florian Kauer <[email protected]>

Fixes #315 Build of sonic-server is failing on NixOS for a few weeks now, see https://hydra.nixos.org/build/239524816 This failing build has been caused by a clang 16 upgrade, because rocksdb depends on a old rust-bindgen version which is not compatible with this version of clang. See rust-lang/rust-bindgen#2312 A resolution is to upgrade rocksdb to its latest version.

Unable to compile with Guile 3.x due to a clang update, which caused bindgen to break: rust-lang/rust-bindgen#2312 This also updates the bindings to GNU Guile 3.0.9.

* Update bindgen Unable to compile with Guile 3.x due to a clang update, which caused bindgen to break: rust-lang/rust-bindgen#2312 This also updates the bindings to GNU Guile 3.0.9. * Update rust edition Use the most recent rust edition (2021) so that any future code is conformant. * Fix clippy lint issues Fix a trivial issue discovered by `cargo clippy'.

…package postgresql14Packages.promscale_extension breaks with: Error: 0: `pgx-0.6.1` shouldn't be used with `cargo-pgx-0.7.4`, please use `pgx = "~0.7.4"` in your `Cargo.toml`. However, pinning cargo-pgx to 0_6_1 via the following buildPgxExtension.override { cargo-pgx = cargo-pgx_0_6_1; } does not work either, because the build then fails with: thread 'main' panicked at /build/promscale_extension-0.8.0-vendor.tar.gz/proc-macro2/src/fallback.rs:756:9: "__mbstate_t_union_(unnamed_at_/nix/store/ij144ma6vs8acil8r9hgr8xkb1dp9azg-glibc-2_39-5-dev/include/bits/types/__mbstate_t_h_16_3)" is not a valid Ident This seems to be related to [1], which indicates that this is a problem with newer LLVM / clang toolchains. At the same time th upstream package is deprecated / archived since the 2nd of April 2024 [2]. Additionally this package is unfree and thus very unlikely to be forked. Since we can't expect this to be fixed, the only sensible thing to do is to remove the package. [1]: rust-lang/rust-bindgen#2312 [2]: timescale/promscale#1836

Bump bindgen to support newer clang versions. See rust-lang/rust-bindgen#2312 Also adapt the types referring to a size to usize, otherwise the new bindgen will no longer accept it. Signed-off-by: Florian Kauer <[email protected]>

Use sysrepo-rs version with newer bindgen version to support newer clang versions. See rust-lang/rust-bindgen#2312 Signed-off-by: Florian Kauer <[email protected]>

Use sysrepo-rs version with newer bindgen version to support newer clang versions. See rust-lang/rust-bindgen#2312 Signed-off-by: Florian Kauer <[email protected]> Reviewed-by: Kurt Kanzenbach <[email protected]>

rust-lang/rust-bindgen#2312

Updates bindgen to fix rust-lang/rust-bindgen#2312

rust-lang/rust-bindgen#2312

emilio mentioned this issue Oct 17, 2022

[regression] libclang no longer reports empty names for anonymous enum/struct/union llvm/llvm-project#58429

Open

pcwalton mentioned this issue Oct 21, 2022

Fix handling of anonymous names in Clang 16. #2316

Closed

emilio mentioned this issue Oct 22, 2022

clang: Detect anonymous items explicitly, rather than relying on empty names. #2319

Merged

emilio closed this as completed in #2319 Oct 22, 2022

publictheta mentioned this issue Mar 24, 2023

Build fails with v0.2.11 on crates.io after updating to Clang 16 RustAudio/coreaudio-sys#75

Closed

This was referenced Mar 30, 2023

build error on too new clang signalapp/boring#18

Closed

build error on too new clang cloudflare/boring#109

Closed

roypat mentioned this issue Mar 31, 2023

firecracker compilation issue on openSUSE Tumbleweed x86_64 firecracker-microvm/firecracker#3584

Closed

ZhongRuoyu mentioned this issue Apr 5, 2023

signal-cli 0.11.8 Homebrew/homebrew-core#127600

Merged

pvdrz mentioned this issue Apr 12, 2023

Unnamed types have a name when switching to llvm >= 16.0.0 #2488

Closed

lnicola mentioned this issue Apr 13, 2023

Error building on mac georust/gdal#387

Closed

im-0 mentioned this issue Apr 18, 2023

error: failed to run custom build command for librocksdb-sys v0.6.1+6.28.2 rust-rocksdb/rust-rocksdb#768

Open

wfchandler mentioned this issue Apr 19, 2023

Unable to build rb-sys with clang 16 due to bindgen issue oxidize-rb/rb-sys#198

Closed

xiangzhai mentioned this issue Apr 28, 2023

"enum_(unnamed_at_/usr/include/linux/loop_h_16_1)" is not a valid Ident AOSC-Archive/aoscdk-rs#7

Closed

mingjunyang mentioned this issue Apr 28, 2023

panicked at '"__mbstate_t_union_(unnamed_at_/usr/include/bits/types/__mbstate_t_h_16_3)" is not a valid Ident', pgcentralfoundation/pgrx#1122

Closed

hawkeye116477 mentioned this issue May 4, 2023

Can't build with Clang 16 BrowserWorks/Waterfox#3027

Open

1 task

shymega pushed a commit to clarkf/guile-rs that referenced this issue Jan 15, 2024

Update bindgen

f2c0ddc

Unable to compile with Guile 3.x due to a clang update, which caused bindgen to break: rust-lang/rust-bindgen#2312 This also updates the bindings to GNU Guile 3.0.9.

shymega pushed a commit to clarkf/guile-rs that referenced this issue Jan 22, 2024

Update bindgen

a7943d1

Unable to compile with Guile 3.x due to a clang update, which caused bindgen to break: rust-lang/rust-bindgen#2312 This also updates the bindings to GNU Guile 3.0.9.

tranzystorekk mentioned this issue Feb 15, 2024

Rust 1.76 void-linux/void-packages#48634

Merged

ianichitei added a commit to bitdefender/bddisasm that referenced this issue Feb 20, 2024

rsbddisasm: Update bindgen to 0.62.0

ba14104

See rust-lang/rust-bindgen#2312

9999years mentioned this issue Feb 21, 2024

Update bindgen to 0.64 sbdchd/squawk#343

Merged

kodiakhq bot pushed a commit to sbdchd/squawk that referenced this issue Feb 21, 2024

Update bindgen to 0.64 (#343)

2b16476

This updates `bindgen` to 0.64, fixing rust-lang/rust-bindgen#2312 (via [`libpg_query-sys`](https://crates.io/crates/libpg_query-sys/0.2.1)) when building from source.

fia0 mentioned this issue Mar 7, 2024

julea: use upstream JULEA parcio/haura#55

Merged

shymega pushed a commit to clarkf/guile-rs that referenced this issue Mar 21, 2024

Update bindgen

c0127d8

Unable to compile with Guile 3.x due to a clang update, which caused bindgen to break: rust-lang/rust-bindgen#2312 This also updates the bindings to GNU Guile 3.0.9.

PsiACE mentioned this issue Apr 6, 2024

fix: make it works with newest toolchain geo-engine/xgboost-rs#1

Open

wolfgangwalther mentioned this issue Apr 20, 2024

promscale_extension,buildPgxExtension: remove NixOS/nixpkgs#305572

Merged

13 tasks

Robbepop mentioned this issue May 4, 2024

Fix wasm3-rs builds wasm3/wasm3-rs#48

Open

FelixMoelder mentioned this issue May 6, 2024

fix: build on aarch64-apple-darwin rust-bio/hts-sys#10

Merged

This was referenced Jun 3, 2024

Bump bindgen version to 0.62.0 zzeroo/libmodbus-rs#20

Closed

Bump bindgen version to 0.62.0 zzeroo/libmodbus-rs#21

Open

varadiz mentioned this issue Jun 18, 2024

Can not compile using LLVM 18 due to old version of bindgen CLevasseur/ta-lib-rust#11

Open

koalo mentioned this issue Jun 24, 2024

Bump bindgen sjtakada/sysrepo-rs#8

Open

Wardenfar added a commit to Wardenfar/libvex-rs that referenced this issue Aug 16, 2024

fix : bump bindgen to handle recent clang breaking change

bf170ea

rust-lang/rust-bindgen#2312

Wardenfar mentioned this issue Aug 16, 2024

Bump bindgen build-dependency to handle clang naming breaking change noam93k/libvex-rs#1

Merged

zachs18 added a commit to zachs18/imagegen-rs that referenced this issue Aug 17, 2024

Update deps. Fix invalid cfg.

b27dd57

Updates bindgen to fix rust-lang/rust-bindgen#2312

noam93k pushed a commit to noam93k/libvex-rs that referenced this issue Aug 18, 2024

fix : bump bindgen to handle recent clang breaking change

edf091a

rust-lang/rust-bindgen#2312

taylordotfish mentioned this issue Aug 31, 2024

Add support for 64-bit PowerPC RustAudio/rust-lv2#116

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

thread 'main' panicked at '"__mbstate_t_(anonymous_struct_at_foo_cc_2_3)" is not a valid Ident' #2312

thread 'main' panicked at '"__mbstate_t_(anonymous_struct_at_foo_cc_2_3)" is not a valid Ident' #2312

glandium commented Oct 17, 2022

emilio commented Oct 17, 2022

glandium commented Oct 17, 2022

emilio commented Oct 18, 2022

glandium commented Oct 18, 2022

glandium commented Oct 18, 2022

pcwalton commented Oct 21, 2022

tgross35 commented Nov 11, 2022

tgross35 commented Nov 11, 2022

thread 'main' panicked at '"__mbstate_t_(anonymous_struct_at_foo_cc_2_3)" is not a valid Ident' #2312

thread 'main' panicked at '"__mbstate_t_(anonymous_struct_at_foo_cc_2_3)" is not a valid Ident' #2312

Comments

glandium commented Oct 17, 2022

Input C/C++ Header

Bindgen Invocation

Actual Results

emilio commented Oct 17, 2022

glandium commented Oct 17, 2022

emilio commented Oct 18, 2022

glandium commented Oct 18, 2022

glandium commented Oct 18, 2022

pcwalton commented Oct 21, 2022

tgross35 commented Nov 11, 2022

tgross35 commented Nov 11, 2022