-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add use_delta_sync
option
#17573
Add use_delta_sync
option
#17573
Conversation
Pull Request Test Coverage Report for Build 8189794206Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
d0e7323
to
1e0aa8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. But I'm not @Chia-Network/required-reviewers, so will need another pair of eyes on it.
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
@felixbrucker looks like there's now a conflict presumably due to #17209 A comment/warning in the default config would also be nice to have, explaining that if you use this option you run the risk (even if it's not likely to be an issue) of missing coin state due to reorgs. Other than that I don't personally have any issue with landing this. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. However, I don't have permission to merge, so will need more review(s).
Purpose:
Improve wallet sync speed
Current Behavior:
Currently there are a few places where subscriptions for puzzle hash and coin updates are requested from 0 every time, instead of the fork height for this sync. This is slow.
New Behavior:
If the
use_delta_sync
option in the wallet config section of theconfig.yaml
is set totrue
the fork height of the sync is used instead and wallet syncing is fast(er).Note:
Generating new puzzle hashes will always sync them from 0, the same is true for subscribing to interested coin ids and puzzle hashes. IMHO the config option could be removed and a delta sync being used always, let me know if you have reservations with that, for now its just a config option which is not enabled by default.