Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move tests #17209

Merged
merged 4 commits into from
Mar 14, 2024
Merged

move tests #17209

merged 4 commits into from
Mar 14, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Jan 4, 2024

Purpose:

This Proposal moves our existing tests into the public part of chia-blockchain - for example, if you pip install chia-blockchain you get all the test code as well.

This makes it quite a bit easier for a consumer of chia-blockchain to use test framework code - for example, things like CDV, nft minter, bridge - all that stuff would have access to testing tooling out of the box.

This involves physically moving the test directory to \ under chia.

The current proposal involves making two "test" directories. chia/tests consists of tooling and frameworks while chia/_tests consists of the specific chia-blockchain tests. This logical separation allows us to suggest that things in _tests are more private to chia-blockchain (or perhaps more specific) while things in chia/tests are more expected to be used publicly by other things.

Primarily this change was to eliminate issues with needing some parts of the test framework (the simulator needs some parts) but not others, and we were running into issues where some developers would move items from tests to chia and other developers would them move back from chia to tests. Making it all public at least solves any issues with which parts should be public.

A secondary benefit was that devs using the wheel have access to all the test framework for their purposes

And finally, a third benefit was the wheel users now can run the tests locally

Current Behavior:

New Behavior:

Testing Notes:

Draft For:

  • general consideration and a final decision
  • removing move script
  • perhaps moving the test utils to chia.tests or chia.testing or...
    • let's take that on separately

@altendky altendky added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Jan 4, 2024
@altendky altendky force-pushed the move_tests branch 2 times, most recently from 392eb30 to e583b50 Compare January 4, 2024 16:09
@github-actions github-actions bot added merge_conflict Branch has conflicts that prevent merge to main labels Jan 4, 2024
Copy link
Contributor

github-actions bot commented Jan 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
Copy link
Contributor

github-actions bot commented Jan 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@altendky altendky mentioned this pull request Jan 5, 2024
@altendky altendky force-pushed the move_tests branch 2 times, most recently from ab43eda to 8bbebf7 Compare January 5, 2024 13:31
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jan 5, 2024
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

coveralls-official bot commented Jan 5, 2024

Pull Request Test Coverage Report for Build 7482539923

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 90.434%

Totals Coverage Status
Change from base Build 7481196968: -0.2%
Covered Lines: 94479
Relevant Lines: 104447

💛 - Coveralls

@altendky altendky force-pushed the move_tests branch 3 times, most recently from 4778d65 to 6d76768 Compare January 5, 2024 14:54
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jan 5, 2024
Copy link
Contributor

github-actions bot commented Jan 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jan 7, 2024
Copy link
Contributor

github-actions bot commented Jan 7, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jan 8, 2024
Copy link
Contributor

github-actions bot commented Jan 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jan 10, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@altendky altendky force-pushed the move_tests branch 2 times, most recently from a0cb7cd to 07964b0 Compare January 10, 2024 16:20
Copy link
Contributor

github-actions bot commented Mar 9, 2024

This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties.

@github-actions github-actions bot added the stale-pr Flagged as stale and in need of manual review label Mar 9, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Mar 12, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added merge_conflict Branch has conflicts that prevent merge to main and removed stale-pr Flagged as stale and in need of manual review labels Mar 12, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Mar 13, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

emlowe
emlowe previously approved these changes Mar 13, 2024
Copy link
Contributor

File Coverage Missing Lines
chia/_tests/build-init-files.py 0.0% lines 67
chia/_tests/build-job-matrix.py 0.0% lines 14, 18, 116, 119, 122, 124, 126-127
chia/_tests/process_junit.py 0.0% lines 15-16
Total Missing Coverage
318 lines 11 lines 96%

@altendky altendky marked this pull request as ready for review March 14, 2024 02:02
@altendky altendky requested a review from a team as a code owner March 14, 2024 02:02
@altendky altendky requested a review from emlowe March 14, 2024 02:02
@emlowe
Copy link
Contributor

emlowe commented Mar 14, 2024

coverage diff exemption

@pmaslana pmaslana merged commit a89222a into main Mar 14, 2024
284 of 285 checks passed
@pmaslana pmaslana deleted the move_tests branch March 14, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants