-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move tests #17209
move tests #17209
Conversation
392eb30
to
e583b50
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ab43eda
to
8bbebf7
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Pull Request Test Coverage Report for Build 7482539923
💛 - Coveralls |
4778d65
to
6d76768
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
a0cb7cd
to
07964b0
Compare
This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed by the relevant parties. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
coverage diff exemption |
Purpose:
This Proposal moves our existing
tests
into the public part ofchia-blockchain
- for example, if youpip install chia-blockchain
you get all thetest
code as well.This makes it quite a bit easier for a consumer of chia-blockchain to use test framework code - for example, things like CDV, nft minter, bridge - all that stuff would have access to testing tooling out of the box.
This involves physically moving the
test
directory to \ underchia
.The current proposal involves making two "test" directories.
chia/tests
consists of tooling and frameworks whilechia/_tests
consists of the specific chia-blockchain tests. This logical separation allows us to suggest that things in_tests
are more private to chia-blockchain (or perhaps more specific) while things inchia/tests
are more expected to be used publicly by other things.Primarily this change was to eliminate issues with needing some parts of the test framework (the
simulator
needs some parts) but not others, and we were running into issues where some developers would move items fromtests
tochia
and other developers would them move back fromchia
totests
. Making it all public at least solves any issues with which parts should be public.A secondary benefit was that devs using the wheel have access to all the test framework for their purposes
And finally, a third benefit was the wheel users now can run the tests locally
Current Behavior:
New Behavior:
Testing Notes:
Draft For:
chia.tests
orchia.testing
or...