-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop automatic transaction pushing by wallets #17436
Commits on Oct 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 75555f5 - Browse repository at this point
Copy the full SHA 75555f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55f519d - Browse repository at this point
Copy the full SHA 55f519dView commit details -
Use TXConfig instead of pending_transactions for coin exclusion in sp…
…end_clawback_coins
Configuration menu - View commit details
-
Copy full SHA for 5102b47 - Browse repository at this point
Copy the full SHA 5102b47View commit details
Commits on Oct 12, 2023
-
Merge remote-tracking branch 'origin/long_lived/vault' into quex.remo…
…ve_ignore_max_send_amount
Configuration menu - View commit details
-
Copy full SHA for 843dcb9 - Browse repository at this point
Copy the full SHA 843dcb9View commit details -
Merge remote-tracking branch 'origin/long_lived/vault' into quex.all_…
…tx_pushing_optional
Configuration menu - View commit details
-
Copy full SHA for 853b793 - Browse repository at this point
Copy the full SHA 853b793View commit details -
Configuration menu - View commit details
-
Copy full SHA for c60b1b1 - Browse repository at this point
Copy the full SHA c60b1b1View commit details
Commits on Oct 17, 2023
-
Merge remote-tracking branch 'origin/long_lived/vault' into quex.all_…
…tx_pushing_optional
Configuration menu - View commit details
-
Copy full SHA for 773e492 - Browse repository at this point
Copy the full SHA 773e492View commit details -
Merge remote-tracking branch 'origin/long_lived/vault' into quex.remo…
…ve_ignore_max_send_amount
Configuration menu - View commit details
-
Copy full SHA for 15103a6 - Browse repository at this point
Copy the full SHA 15103a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c1b289 - Browse repository at this point
Copy the full SHA 4c1b289View commit details
Commits on Oct 19, 2023
-
Merge remote-tracking branch 'origin/long_lived/vault' into quex.remo…
…ve_ignore_max_send_amount
Configuration menu - View commit details
-
Copy full SHA for 5e9002f - Browse repository at this point
Copy the full SHA 5e9002fView commit details -
Merge remote-tracking branch 'origin/long_lived/vault' into quex.all_…
…tx_pushing_optional
Configuration menu - View commit details
-
Copy full SHA for 8ae964d - Browse repository at this point
Copy the full SHA 8ae964dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ba148e - Browse repository at this point
Copy the full SHA 2ba148eView commit details
Commits on Oct 30, 2023
-
Merge remote-tracking branch 'origin/long_lived/vault' into quex.remo…
…ve_ignore_max_send_amount
Configuration menu - View commit details
-
Copy full SHA for 409f5d5 - Browse repository at this point
Copy the full SHA 409f5d5View commit details
Commits on Oct 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cd64522 - Browse repository at this point
Copy the full SHA cd64522View commit details
Commits on Nov 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 46e816a - Browse repository at this point
Copy the full SHA 46e816aView commit details
Commits on Nov 2, 2023
-
Remove
ignore_max_send_amount
(#16395)This is a very old parameter that we've been propogating through new version of generate signed transaction for (it seems to me) no reason. The only instances in which this parameter is actually set to `True` we manually specify the set of coins anyway. Perhaps the idea is to prevent choosing coins that won't fit in a block, but such an unlikely error will still get caught by the mempool and there's a million other similar errors that would behave that way as well. I think more likely the intention was simply for testing in tests that have since been re-written or deleted.
Configuration menu - View commit details
-
Copy full SHA for 188bb20 - Browse repository at this point
Copy the full SHA 188bb20View commit details -
Merge remote-tracking branch 'origin/long_lived/vault' into quex.all_…
…tx_pushing_optional
Configuration menu - View commit details
-
Copy full SHA for 83e980e - Browse repository at this point
Copy the full SHA 83e980eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ba8a75 - Browse repository at this point
Copy the full SHA 3ba8a75View commit details
Commits on Nov 6, 2023
-
Don't autopush txs across RPC (#16314)
This PR is a step in the direction of a more observer-style wallet. Currently, most of our wallet functions just push directly to the network as a matter of course when creating a transaction. While this is convenient (especially in tests) it will be impossible should we get to a wallet design that does not contain the private key as a key component to wallet operations. For now, the wallet still signs the transaction and has it ready to be pushed to the network should the user specify that. But all of the pushing logic has been migrated to the top-most layer available (usually the RPC) so that the user always has control over whether or not they would like to immediately push the transaction. In addition, any transaction method in the RPC now returns a `"transactions"` key so that it is easy for a front-end client to have everything they need to push the transaction as if the wallet was doing it (using the `push_transactions` endpoint).
Configuration menu - View commit details
-
Copy full SHA for 008f3ba - Browse repository at this point
Copy the full SHA 008f3baView commit details
Commits on Nov 8, 2023
-
Use TXConfig instead of pending_transactions for coin exclusion in sp…
…end_clawback_coins (#16354) Previously, this logic depended on pushing clawback transactions to the wallet DB to be submitted so that on further transaction generations, the same coins would not be selected. With the change to make all transaction pushing optional, this logic no longer functioned correctly. This change leverages the `excluded_coin_ids` key in the `TXConfig` to exclude coins between transaction batches instead, resulting in a stateless generation of these transactions (fitting the new pattern).
Configuration menu - View commit details
-
Copy full SHA for 33a053e - Browse repository at this point
Copy the full SHA 33a053eView commit details
Commits on Jan 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 122e28c - Browse repository at this point
Copy the full SHA 122e28cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3759d2 - Browse repository at this point
Copy the full SHA f3759d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for dee1b97 - Browse repository at this point
Copy the full SHA dee1b97View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6ea806 - Browse repository at this point
Copy the full SHA e6ea806View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a39009 - Browse repository at this point
Copy the full SHA 4a39009View commit details
Commits on Jan 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ee99424 - Browse repository at this point
Copy the full SHA ee99424View commit details