Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop automatic transaction pushing by wallets #17436

Merged
merged 26 commits into from
Jan 31, 2024
Merged

Commits on Oct 11, 2023

  1. Configuration menu
    Copy the full SHA
    75555f5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    55f519d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5102b47 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Merge remote-tracking branch 'origin/long_lived/vault' into quex.remo…

    …ve_ignore_max_send_amount
    Quexington committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    843dcb9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    853b793 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c60b1b1 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Configuration menu
    Copy the full SHA
    773e492 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/long_lived/vault' into quex.remo…

    …ve_ignore_max_send_amount
    Quexington committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    15103a6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4c1b289 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Merge remote-tracking branch 'origin/long_lived/vault' into quex.remo…

    …ve_ignore_max_send_amount
    Quexington committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    5e9002f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8ae964d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2ba148e View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Merge remote-tracking branch 'origin/long_lived/vault' into quex.remo…

    …ve_ignore_max_send_amount
    Quexington committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    409f5d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Configuration menu
    Copy the full SHA
    cd64522 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Configuration menu
    Copy the full SHA
    46e816a View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Remove ignore_max_send_amount (#16395)

    This is a very old parameter that we've been propogating through new
    version of generate signed transaction for (it seems to me) no reason.
    The only instances in which this parameter is actually set to `True` we
    manually specify the set of coins anyway. Perhaps the idea is to prevent
    choosing coins that won't fit in a block, but such an unlikely error
    will still get caught by the mempool and there's a million other similar
    errors that would behave that way as well. I think more likely the
    intention was simply for testing in tests that have since been
    re-written or deleted.
    Quexington authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    188bb20 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    83e980e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3ba8a75 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Don't autopush txs across RPC (#16314)

    This PR is a step in the direction of a more observer-style wallet.
    
    Currently, most of our wallet functions just push directly to the
    network as a matter of course when creating a transaction. While this is
    convenient (especially in tests) it will be impossible should we get to
    a wallet design that does not contain the private key as a key component
    to wallet operations.
    
    For now, the wallet still signs the transaction and has it ready to be
    pushed to the network should the user specify that. But all of the
    pushing logic has been migrated to the top-most layer available (usually
    the RPC) so that the user always has control over whether or not they
    would like to immediately push the transaction.
    
    In addition, any transaction method in the RPC now returns a
    `"transactions"` key so that it is easy for a front-end client to have
    everything they need to push the transaction as if the wallet was doing
    it (using the `push_transactions` endpoint).
    Quexington authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    008f3ba View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Use TXConfig instead of pending_transactions for coin exclusion in sp…

    …end_clawback_coins (#16354)
    
    Previously, this logic depended on pushing clawback transactions to the
    wallet DB to be submitted so that on further transaction generations,
    the same coins would not be selected. With the change to make all
    transaction pushing optional, this logic no longer functioned correctly.
    This change leverages the `excluded_coin_ids` key in the `TXConfig` to
    exclude coins between transaction batches instead, resulting in a
    stateless generation of these transactions (fitting the new pattern).
    Quexington authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    33a053e View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Configuration menu
    Copy the full SHA
    122e28c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f3759d2 View commit details
    Browse the repository at this point in the history
  3. merge fixes

    Quexington committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    dee1b97 View commit details
    Browse the repository at this point in the history
  4. Inadvertent diffs

    Quexington committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    e6ea806 View commit details
    Browse the repository at this point in the history
  5. Inadvertent change

    Quexington committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    4a39009 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Inadvertent diff.

    AmineKhaldi committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    ee99424 View commit details
    Browse the repository at this point in the history