Stop automatic transaction pushing by wallets #17436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…end_clawback_coins
…ve_ignore_max_send_amount
…tx_pushing_optional
…tx_pushing_optional
…ve_ignore_max_send_amount
…ve_ignore_max_send_amount
…tx_pushing_optional
…ve_ignore_max_send_amount
This is a very old parameter that we've been propogating through new version of generate signed transaction for (it seems to me) no reason. The only instances in which this parameter is actually set to `True` we manually specify the set of coins anyway. Perhaps the idea is to prevent choosing coins that won't fit in a block, but such an unlikely error will still get caught by the mempool and there's a million other similar errors that would behave that way as well. I think more likely the intention was simply for testing in tests that have since been re-written or deleted.
…tx_pushing_optional
This PR is a step in the direction of a more observer-style wallet. Currently, most of our wallet functions just push directly to the network as a matter of course when creating a transaction. While this is convenient (especially in tests) it will be impossible should we get to a wallet design that does not contain the private key as a key component to wallet operations. For now, the wallet still signs the transaction and has it ready to be pushed to the network should the user specify that. But all of the pushing logic has been migrated to the top-most layer available (usually the RPC) so that the user always has control over whether or not they would like to immediately push the transaction. In addition, any transaction method in the RPC now returns a `"transactions"` key so that it is easy for a front-end client to have everything they need to push the transaction as if the wallet was doing it (using the `push_transactions` endpoint).
…end_clawback_coins (#16354) Previously, this logic depended on pushing clawback transactions to the wallet DB to be submitted so that on further transaction generations, the same coins would not be selected. With the change to make all transaction pushing optional, this logic no longer functioned correctly. This change leverages the `excluded_coin_ids` key in the `TXConfig` to exclude coins between transaction batches instead, resulting in a stateless generation of these transactions (fitting the new pattern).
Quexington
added
the
Changed
github-actions
bot
added
the
merge_conflict
github-actions
bot
removed
the
merge_conflict
AmineKhaldi
approved these changes
Jan 31, 2024
arvidn
reviewed
Feb 2, 2024
| *args, | ||
| tx_config=tx_config, | ||
| extra_conditions=extra_conditions, | ||
| **({"push": push} if push is not None else {}), |
There was a problem hiding this comment.
It doesn't looks like the function distinguishes between this argument being passed as True and not being passed at all. wouldn't it look a bit simpler to just say:
Suggested change
| **({"push": push} if push is not None else {}), | |
| push = False if push is None else True, |
There was a problem hiding this comment.
Some cases default to true and some default to false.
There was a problem hiding this comment.
Yeah as @AmineKhaldi said, the idea is to omit the push key for the API side default if no value is specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreation of #16314 & #16354 @ main. Two PRs are included because the latter is a bug fix for the former.
Source hash: 008f3ba^..33a053e
Remaining commits: 14