Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate file lists for workflows instead of wildcard patterns #11117

Merged
merged 3 commits into from
Apr 21, 2022
Merged

generate file lists for workflows instead of wildcard patterns #11117

merged 3 commits into from
Apr 21, 2022

Conversation

altendky
Copy link
Contributor

This pulls the control of the file list into our generation code rather than leaving it to OS-varying mechanisms like wildcard expansion.

Extracted from #10681.

@altendky altendky mentioned this pull request Apr 10, 2022
Merged
7 tasks
hoffmang9
hoffmang9 previously approved these changes Apr 10, 2022
View reviewed changes
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending CI

@altendky altendky added the ready_to_merge Submitter and reviewers think this is ready label Apr 10, 2022
@wjblanke
Copy link
Contributor

conflicts.... i also hesitate on this because new files wont automatically get included with this change

@altendky
Copy link
Contributor Author

The code changing here is part of the workflow generation. The workflows are verified to be up to date in CI itself by that same script making sure that it would not introduce any changes. It certainly could have a bug but at the basic level the workflows are certainly checked for being out of date.

@altendky altendky removed the ready_to_merge Submitter and reviewers think this is ready label Apr 20, 2022
@altendky
Copy link
Contributor Author

Testing my claim at #11244.

@altendky
Copy link
Contributor Author

Looks good.

https://github.com/Chia-Network/chia-blockchain/runs/6103492133?check_suite_focus=true

image

@altendky altendky requested a review from wjblanke April 20, 2022 23:05
emlowe
emlowe approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@emlowe emlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve

@altendky altendky added the ready_to_merge Submitter and reviewers think this is ready label Apr 21, 2022
@wjblanke wjblanke merged commit aaf3fbc into main Apr 21, 2022
@wjblanke wjblanke deleted the generate_file_list_not_wildcard branch April 21, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

@hoffmang9 hoffmang9 hoffmang9 left review comments

@wjblanke wjblanke Awaiting requested review from wjblanke

Assignees
No one assigned
Labels
ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@altendky @wjblanke @hoffmang9 @emlowe