Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows CI #10681

Merged
merged 132 commits into from
May 31, 2022
Merged

Add Windows CI #10681

merged 132 commits into from
May 31, 2022

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Mar 12, 2022

Draft for:

Items to note.

The build workflow script currently sets -n 0 for all windows tests and ignores the config Parallel setting. Windows tests do work locally quite well with multiple subprocesses, however, the GH runners stumble with 4 processes in some tests. Subsequent PRs can explore expanding the config to have a dict with per OS settings.

The IPv6 test is skipped (also skipped on macOS).

@altendky altendky closed this Apr 3, 2022
@altendky altendky reopened this Apr 3, 2022
@lgtm-com
Copy link

lgtm-com bot commented May 24, 2022

This pull request introduces 1 alert when merging 7e823e0 into 60c1867 - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented May 24, 2022

This pull request introduces 1 alert when merging 317e632 into 60c1867 - view on LGTM.com

new alerts:

  • 1 for Unused import

tests/build-workflows.py Outdated Show resolved Hide resolved
tests/testconfig.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented May 24, 2022

This pull request introduces 1 alert when merging 2fb0996 into 60c1867 - view on LGTM.com

new alerts:

  • 1 for Unused import

emlowe
emlowe previously approved these changes May 24, 2022
Copy link
Contributor

@emlowe emlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve

@emlowe emlowe requested review from mariano54 and xdustinface May 24, 2022 20:16
xdustinface
xdustinface previously approved these changes May 24, 2022
Copy link
Contributor

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, two nits to maybe address, or not :)

tests/pools/test_pool_rpc.py Outdated Show resolved Hide resolved
@altendky altendky dismissed stale reviews from xdustinface and emlowe via fe6825a May 25, 2022 01:26
@lgtm-com
Copy link

lgtm-com bot commented May 25, 2022

This pull request introduces 1 alert when merging fe6825a into 9f50bb3 - view on LGTM.com

new alerts:

  • 1 for Unused import

Copy link
Contributor

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LGTM alert indeed was introduced here because you removed the usage of Path in tests/pools/test_pool_config.py and it seems like i made the Windows CI unhappy again with some path related issues via #11625, sorry :) Seems like its related to the path string matching in with pytest.raises(ValueError, match=f"Path doesn't exist: {test_path}")?

@lgtm-com
Copy link

lgtm-com bot commented May 27, 2022

This pull request introduces 1 alert when merging adcbd02 into 5844c6c - view on LGTM.com

new alerts:

  • 1 for Unused import

@altendky altendky added the ready_to_merge Submitter and reviewers think this is ready label May 27, 2022
@emlowe emlowe linked an issue May 27, 2022 that may be closed by this pull request
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@wallentx wallentx merged commit 8b2f7ec into main May 31, 2022
@wallentx wallentx deleted the windows_ci branch May 31, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unexplored Windows CI failures
8 participants