Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder module - Fix idempotency when using attributes parameter for c… #558

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

lgetwan
Copy link
Contributor

@lgetwan lgetwan commented Feb 14, 2024

Folder module - Fix idempotency

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When using the attributes parameter for creating a folder, a folder without explicit attributes is created.
When using the update_attributes parameter instead, the folder will get the expected attributes.

What is the new behavior?

Both, attributes & update_attributes can be used to create a folder, and both set the attributes correctly.

@github-actions github-actions bot added the module:folder This affects the folder module label Feb 14, 2024
@robin-checkmk robin-checkmk self-assigned this Feb 15, 2024
@robin-checkmk robin-checkmk mentioned this pull request Feb 15, 2024
7 tasks
@robin-checkmk robin-checkmk merged commit 1b856a3 into devel Feb 15, 2024
30 checks passed
@robin-checkmk robin-checkmk added the release:4.3.0 Affects the mentioned release. label Feb 15, 2024
@robin-checkmk robin-checkmk deleted the fix/folder_module_idempotency branch February 15, 2024 15:08
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
@robin-checkmk robin-checkmk added the bug Something isn't working label Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working module:folder This affects the folder module release:4.3.0 Affects the mentioned release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] update_attributes on folder with network scan enabled (and a network scan result present) fails
2 participants