Merge pull request #558 from Checkmk/fix/folder_module_idempotency

Folder module - Fix idempotency when using attributes parameter for c…
Checkmk · Feb 15, 2024 · 1b856a3 · 1b856a3
2 parents e31d1ae + 66e0b06
commit 1b856a3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/changelogs/fragments/fix_folder_module_idempotency.yml b/changelogs/fragments/fix_folder_module_idempotency.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - Folder module - Fix idempotency when using "attributes" parameter for creating a folder.
diff --git a/plugins/modules/folder.py b/plugins/modules/folder.py
@@ -407,7 +407,7 @@ def needs_update(self):
 
     def create(self):
         data = self.desired.copy()
-        if data.get("attributes", {}) != {}:
+        if data.get("attributes", {}) == {}:
             data["attributes"] = data.pop("update_attributes", {})
 
         if data.get("remove_attributes"):
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		bugfixes:
		- Folder module - Fix idempotency when using "attributes" parameter for creating a folder.