chore: improve appearance of Twitch emotes in popup #5632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
commented
Oct 7, 2024
Comment on lines
+497
to
+504
| // some bit emote-sets have an id, but we want to combine them into a | ||
| // single set | ||
| if (isBits) | ||
| { | ||
| return emote.setID; | ||
| return TWITCH_BIT_EMOTE_SET_PREFIX % emote.ownerID; | ||
| } | ||
|
|
||
| if (isSub) | ||
| { | ||
| return TWITCH_SUB_EMOTE_SET_PREFIX % emote.ownerID; | ||
| } | ||
| // isBits | ||
| return TWITCH_BIT_EMOTE_SET_PREFIX % emote.ownerID; | ||
| // isSub | ||
| return TWITCH_SUB_EMOTE_SET_PREFIX % emote.ownerID; |
There was a problem hiding this comment.
just relaized I could make this more readable by checking bits/subs first, but let's see if this works at all
|
@digitizeddave could you try the appimage from this PR (https://github.com/Chatterino/chatterino2/actions/runs/11217307145?pr=5632, at the bottom)? |
Yes, that is organized much better! It's alphabetized and the bits are next to their respective channels. |
pajlada
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5631 (hopefully)