-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Un-singletonize Paths & Updates #5092
Merged
Merged
Changes from 29 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
0dcd189
Make all uses/storages of Paths const
pajlada ff87089
store Paths as a unique_ptr instead of a raw ptr
pajlada 8d24a2b
Make Paths accessible from Application
pajlada eb96bd5
make Paths isPortable const
pajlada 1bf40b7
mark Paths.isPortable as deprecated
pajlada 8928f59
Remove getPaths() usage from Args
pajlada 7c2ec8c
Remove getPaths() usage from NetworkPrivate
pajlada e85d060
Remove getPaths() usage from GeneralPage
pajlada e313575
Remove getPaths() usage from PluginsPage
pajlada 53599a6
Remove getPaths() usage from Credentials
pajlada 42def13
Remove getPaths() usage from Irc2
pajlada 601e87f
Remove getPaths() usage from Toasts
pajlada f524f3b
Remove getPaths() usage from WindowManager
pajlada 199b22d
Remove getPaths() usage from LoggingChannel
pajlada 6ad5c63
Remove getPaths() usage from NetworkTask
pajlada 3f599ea
Remove getPaths() usage from CrashHandler
pajlada a2e9177
Remove getPaths() usage from LastRunCrashDialog
pajlada 72b3d6a
Remove getPaths() usage from ImageUploader
pajlada 6d0db89
Remove getPaths() usage from Theme
pajlada 4993a77
Remove getPaths() usage from ModerationPage
pajlada 6955771
Remove getPaths() usage from UserDataController
pajlada b3d9f72
Remove getPaths() usage from PluginController
pajlada c98d548
Make Updates non-singletonized, removing usage of getPaths()
pajlada b258187
remove getPaths()
pajlada b649fe2
Add changelog entry
pajlada 3eb4a14
Fix missing const args for PluginController
pajlada dac2ef3
const more args
pajlada 98cae26
fix plugin compilation
pajlada b37b6c4
fix plugins compile
pajlada 596484f
Add comment to the Updates class describing what it does
pajlada 44503d2
fix changelog entry number
pajlada 78c028d
Remove explicit CrashHandler template param
pajlada d46b553
Don't use getIApp()->getPaths() in Theme
pajlada File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems scary. There should be a comment in the
Updates
constructor saying that it must never check for updates right away.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How so? (Also this is the mock app)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd assume that once I initialize the updates, it will eventually check for updates (or some other component will trigger it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing new in this PR really, except that we know where Updates is initialized. I have added some documentation to the
Updates
class in596484f
(#5092)