refactor: Un-singletonize Paths & Updates #5092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
force-pushed
the
refactor/paths
branch
from
dc30ab1
to
b258187
Compare
Nerixyz
reviewed
Jan 16, 2024
|
|
||
| namespace chatterino::mock { | ||
|
|
||
| class EmptyApplication : public IApplication | ||
| { | ||
| public: | ||
| EmptyApplication() | ||
| : updates_(this->paths_) |
There was a problem hiding this comment.
This seems scary. There should be a comment in the Updates constructor saying that it must never check for updates right away.
There was a problem hiding this comment.
How so? (Also this is the mock app)
There was a problem hiding this comment.
I'd assume that once I initialize the updates, it will eventually check for updates (or some other component will trigger it).
There was a problem hiding this comment.
Nothing new in this PR really, except that we know where Updates is initialized. I have added some documentation to the Updates class in 596484f (#5092)
No longer necessary since we call new CrashHandler
1 task
devJimmyboy
pushed a commit
to devJimmyboy/chatterino7
that referenced
this pull request
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unsingletonize Paths, I had to unsingletonize Updates
Nothing groundbreaking, but there's a few things to check & review before merging this in. There's probably also a few places that could bypass the
getIApp()->getPaths()workaround