Show historic timeouts and bans in usercard #4760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerixyz
force-pushed
the
fix/timeout-thingy
branch
from
1cc36dc
to
64bd77b
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pajlada
force-pushed
the
fix/timeout-thingy
branch
from
e5d1252
to
368fbd5
Compare
pajlada
approved these changes
Aug 12, 2023
There was a problem hiding this comment.
This change is fine to me - it was not difficult to test.
One quirk it has that I documented in ChannelHelpers is that timeouts can be merged into historic message timeouts even though they technically wouldn't if that timeout was a normal message, since we rely on the parse time of a message to know if we should merge into it.
I'm OK with the implementation as-is since it would require a pretty heavy lift to fix this issue.
Let me know if you are comfortable having this PR merged in
pajlada
approved these changes
Aug 13, 2023
Nerixyz
added a commit
to Nerixyz/chatterino2
that referenced
this pull request
Aug 19, 2023
Co-authored-by: Rasmus Karlsson <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes timeouts and bans of users not being shown in their usercard and timeouts not stacking. Previously,
CLEARCHATs were converted toNOTICEs. This was removed andCLEARCHATs are handled.The fix is a bit more involved, as the
addOrReplaceMessagelogic now adapts to any buffer. I wasn't very sure where to put the shared logic, so I choseChannelHelpers(analogous toIrcHelpers).Fixes #3030.