-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show historic timeouts and bans in usercard #4760
Conversation
1cc36dc
to
64bd77b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
e5d1252
to
368fbd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is fine to me - it was not difficult to test.
One quirk it has that I documented in ChannelHelpers is that timeouts can be merged into historic message timeouts even though they technically wouldn't if that timeout was a normal message, since we rely on the parse time of a message to know if we should merge into it.
I'm OK with the implementation as-is since it would require a pretty heavy lift to fix this issue.
Let me know if you are comfortable having this PR merged in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Co-authored-by: Rasmus Karlsson <[email protected]>
Description
This PR fixes timeouts and bans of users not being shown in their usercard and timeouts not stacking. Previously,
CLEARCHAT
s were converted toNOTICE
s. This was removed andCLEARCHAT
s are handled.The fix is a bit more involved, as the
addOrReplaceMessage
logic now adapts to any buffer. I wasn't very sure where to put the shared logic, so I choseChannelHelpers
(analogous toIrcHelpers
).Fixes #3030.