Usernames in historic bans / timeouts aren't clickable.

[Mm2PL]

Describe your issue

Bans / timeouts loaded from recent-messages aren't processed the same way as from chat so they don't have usercard links added.

Expected behavior

You can click usernames from bans in historic messages.

Actual behavior

You can't

OS and Chatterino Version

Chatterino + Dankerino patches 2.3.3 4cc402a upstream faafbda

[zneix]

CLEARCHAT messages retrieved from recent-messages are actually converted to a NOTICE messages, so we'd need to change that logic first if we want to implement this.

See:

chatterino2/src/providers/twitch/TwitchChannel.cpp

Lines 54 to 95 in a84e62c

	auto convertClearchatToNotice(Communi::IrcMessage *message)
	{
	auto channelName = message->parameter(0);
	QString noticeMessage{};
	if (message->tags().contains("target-user-id"))
	{
	auto target = message->parameter(1);
	if (message->tags().contains("ban-duration"))
	{
	// User was timed out
	noticeMessage =
	QString("%1 has been timed out for %2.")
	.arg(target)
	.arg(formatTime(
	message->tag("ban-duration").toString()));
	}
	else
	{
	// User was permanently banned
	noticeMessage =
	QString("%1 has been permanently banned.").arg(target);
	}
	}
	else
	{
	// Chat was cleared
	noticeMessage = "Chat has been cleared by a moderator.";
	}
	// rebuild the raw irc message so we can convert it back to an ircmessage again!
	// this could probably be done in a smarter way
	auto s = QString(":tmi.twitch.tv NOTICE %1 :%2")
	.arg(channelName)
	.arg(noticeMessage);
	auto newMessage = Communi::IrcMessage::fromData(s.toUtf8(), nullptr);
	newMessage->setTags(message->tags());
	return newMessage;
	}