Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use AssocQueryString instead of directly querying the registry #4362

Merged
merged 11 commits into from
Feb 11, 2023
Merged

use AssocQueryString instead of directly querying the registry #4362

merged 11 commits into from
Feb 11, 2023

Commits on Feb 9, 2023

  1. use AssocQueryString instead of directly querying the registry

    @sheybey
    sheybey committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    2674d59 View commit details
    Browse the repository at this point in the history

  2. update CHANGELOG.md

    @sheybey
    sheybey committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    80ba932 View commit details
    Browse the repository at this point in the history

  3. move windows-specific code for opening incognito links to WindowsHelp… 

    …er.cpp
    @sheybey
    sheybey committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    4dba260 View commit details
    Browse the repository at this point in the history

  4. update CHANGELOG.md

    @sheybey
    sheybey committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    6be7c8a View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. getAssociatedCommand() style fixes 

     - use enum class instead of typedef and correct naming style for
   AssociationQueryType
 - use correct include path and order for local include
 - don't use unnecessary ASSOCF_VERIFY flag
 - check return code of both AssocQueryStringW calls
 - use wchar_t instead of TCHAR alias
    @sheybey
    sheybey committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    7f11f21 View commit details
    Browse the repository at this point in the history

  2. use FAILED instead of !SUCCEEDED

    @sheybey
    sheybey committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    e5d40f6 View commit details
    Browse the repository at this point in the history

  3. return early if LoadLibrary fails

    @sheybey
    sheybey committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    434e513 View commit details
    Browse the repository at this point in the history

  4. fix off-by-one error in getAssociatedCommand()

    @sheybey
    sheybey committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    75b6c3a View commit details
    Browse the repository at this point in the history

  5. return early if association is the empty string 

    This avoids returning an empty but not null QString if the stored
association has an empty command.
    @sheybey
    sheybey committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    9b481dc View commit details
    Browse the repository at this point in the history

  6. Check resultSize <= 1 instead of == 0 || == 1 

    Also split up the FAILED check & resultSize checks into separate if-statements
    @pajlada
    pajlada committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    96633eb View commit details
    Browse the repository at this point in the history

  7. Replace NULLs with nullptr

    @pajlada
    pajlada committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    90ec757 View commit details
    Browse the repository at this point in the history