-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use AssocQueryString instead of directly querying the registry #4362
Merged
Commits on Feb 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2674d59 - Browse repository at this point
Copy the full SHA 2674d59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80ba932 - Browse repository at this point
Copy the full SHA 80ba932View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4dba260 - Browse repository at this point
Copy the full SHA 4dba260View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6be7c8a - Browse repository at this point
Copy the full SHA 6be7c8aView commit details
Commits on Feb 10, 2023
-
getAssociatedCommand() style fixes
- use enum class instead of typedef and correct naming style for AssociationQueryType - use correct include path and order for local include - don't use unnecessary ASSOCF_VERIFY flag - check return code of both AssocQueryStringW calls - use wchar_t instead of TCHAR alias
Configuration menu - View commit details
-
Copy full SHA for 7f11f21 - Browse repository at this point
Copy the full SHA 7f11f21View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5d40f6 - Browse repository at this point
Copy the full SHA e5d40f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 434e513 - Browse repository at this point
Copy the full SHA 434e513View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75b6c3a - Browse repository at this point
Copy the full SHA 75b6c3aView commit details -
return early if association is the empty string
This avoids returning an empty but not null QString if the stored association has an empty command.
Configuration menu - View commit details
-
Copy full SHA for 9b481dc - Browse repository at this point
Copy the full SHA 9b481dcView commit details -
Check resultSize <= 1 instead of == 0 || == 1
Also split up the FAILED check & resultSize checks into separate if-statements
Configuration menu - View commit details
-
Copy full SHA for 96633eb - Browse repository at this point
Copy the full SHA 96633ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 90ec757 - Browse repository at this point
Copy the full SHA 90ec757View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.