use AssocQueryString instead of directly querying the registry #4362
Conversation
There was a problem hiding this comment.
Overall the functionality of this change looks good, just some refactoring to leave the windows-specific implementation in its own file would be nice.
As a consequence of this change, Windows builds that do build without the Windows SDK enabled will no longer support incognito links. This is something I'm fine with.
I also plan to implement linux support (well, freedesktop support) for this in a separate PR. Should I create a new XDGHelper or LinuxHelper file for that? |
Yes, for that sort of functionality additional OS-specific helper files in the same directory is fine (i.e. LinuxHelpers.cpp/hpp) |
- use enum class instead of typedef and correct naming style for AssociationQueryType - use correct include path and order for local include - don't use unnecessary ASSOCF_VERIFY flag - check return code of both AssocQueryStringW calls - use wchar_t instead of TCHAR alias
This avoids returning an empty but not null QString if the stored association has an empty command.
Also split up the FAILED check & resultSize checks into separate if-statements
|
@sheybey I pushed two commits, are you ok with a merge after the changes I made? |
Looks good to me |
Pull request checklist:
CHANGELOG.mdwas updated, if applicableThe existing getCommand() in IncognitoBrowser.cpp directly queries undocumented registry keys which could break if Windows decides to change the registry layout (as they have in the past.)
This PR changes getCommand() to instead call AssocQueryString, which smooths out differences between versions of Windows.