Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gemini-exp-1206, gemini-2.0-flash-thinking-exp-1219 #5959

Merged
merged 2 commits into from
Dec 21, 2024
Merged

add gemini-exp-1206, gemini-2.0-flash-thinking-exp-1219 #5959

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a056a7
add gemini-exp-1206, gemini-2.0-flash-thinking-exp-1219
dupl Dec 21, 2024
93ac0e5
Reorganized the Gemini model
dupl Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/constant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,15 @@ const googleModels = [
"gemini-exp-1121",
"learnlm-1.5-pro-experimental",
"gemini-2.0-flash-exp",
"gemini-1.5-flash",
"gemini-1.5-flash-002",
"gemini-1.5-flash-8b",
"gemini-1.5-flash-exp-0827",
"gemini-1.5-pro",
"gemini-1.5-pro-002",
"gemini-1.5-pro-exp-0827",
"gemini-2.0-flash-thinking-exp-1219",
"gemini-exp-1206",
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Add knowledge cutoff dates for new Gemini models.

The new Gemini models (gemini-exp-1206 and gemini-2.0-flash-thinking-exp-1219) should have their knowledge cutoff dates defined in the KnowledgeCutOffDate object to ensure accurate information is displayed to users.

 export const KnowledgeCutOffDate: Record<string, string> = {
   default: "2021-09",
   "gpt-4-turbo": "2023-12",
   "gpt-4-turbo-2024-04-09": "2023-12",
   "gpt-4-turbo-preview": "2023-12",
   "gpt-4o": "2023-10",
   "gpt-4o-2024-05-13": "2023-10",
   "gpt-4o-2024-08-06": "2023-10",
   "gpt-4o-2024-11-20": "2023-10",
   "chatgpt-4o-latest": "2023-10",
   "gpt-4o-mini": "2023-10",
   "gpt-4o-mini-2024-07-18": "2023-10",
   "gpt-4-vision-preview": "2023-04",
   "o1-mini": "2023-10",
   "o1-preview": "2023-10",
   "gemini-pro": "2023-12",
   "gemini-pro-vision": "2023-12",
+  "gemini-exp-1206": "2023-12",
+  "gemini-2.0-flash-thinking-exp-1219": "2023-12",
 };

Committable suggestion skipped: line range outside the PR's diff.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move 1.5 together

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dogtiti, understood! We can group those β€œ1.5” variants so that all gemini-1.5 entries appear together in the list. Once you confirm the exact desired ordering, we’ll move them in the array accordingly. Let me know if this arrangement works for you or if you have a specific sequence in mind.

Copy link

@daiaji daiaji Dec 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The KnowledgeCutOffDate function really should be updated to include the new Gemini models. It seems like it hasn't been updated in quite a while, and gemini-pro and gemini-pro-vision appear to be deprecated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

];

const anthropicModels = [
Expand Down