-
Notifications
You must be signed in to change notification settings - Fork 60k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gemini-exp-1206, gemini-2.0-flash-thinking-exp-1219 #5959
Conversation
@dupl is attempting to deploy a commit to the NextChat Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe pull request updates the Changes
Possibly related PRs
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
π§Ή Nitpick comments (1)
app/constant.ts (1)
328-336
: Consider reorganizing the Gemini models array for better maintainability.Consider grouping the models by their status (stable vs. experimental) and adding deprecation comments for experimental models. This would make it easier to maintain the list as models evolve.
const googleModels = [ "gemini-1.0-pro", // Deprecated on 2/15/2025 "gemini-1.5-pro-latest", "gemini-1.5-flash-latest", "gemini-1.5-flash-8b-latest", - "gemini-exp-1114", - "gemini-exp-1121", - "learnlm-1.5-pro-experimental", - "gemini-2.0-flash-exp", "gemini-1.5-flash", "gemini-1.5-flash-002", "gemini-1.5-flash-8b", - "gemini-1.5-flash-exp-0827", "gemini-1.5-pro", "gemini-1.5-pro-002", - "gemini-1.5-pro-exp-0827", - "gemini-2.0-flash-thinking-exp-1219", - "gemini-exp-1206", + // Experimental models + "gemini-exp-1114", + "gemini-exp-1121", + "learnlm-1.5-pro-experimental", + "gemini-2.0-flash-exp", + "gemini-1.5-flash-exp-0827", + "gemini-1.5-pro-exp-0827", + "gemini-2.0-flash-thinking-exp-1219", // Added in PR #5959 + "gemini-exp-1206", // Added in PR #5959 ];
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
π Files selected for processing (1)
app/constant.ts
(1 hunks)
π Additional comments (1)
app/constant.ts (1)
328-336
: LGTM! New Gemini models added successfully.
The new Gemini models follow the established naming convention and align with the PR objectives.
app/constant.ts
Outdated
"gemini-1.5-flash", | ||
"gemini-1.5-flash-002", | ||
"gemini-1.5-flash-8b", | ||
"gemini-1.5-flash-exp-0827", | ||
"gemini-1.5-pro", | ||
"gemini-1.5-pro-002", | ||
"gemini-1.5-pro-exp-0827", | ||
"gemini-2.0-flash-thinking-exp-1219", | ||
"gemini-exp-1206", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add knowledge cutoff dates for new Gemini models.
The new Gemini models (gemini-exp-1206
and gemini-2.0-flash-thinking-exp-1219
) should have their knowledge cutoff dates defined in the KnowledgeCutOffDate
object to ensure accurate information is displayed to users.
export const KnowledgeCutOffDate: Record<string, string> = {
default: "2021-09",
"gpt-4-turbo": "2023-12",
"gpt-4-turbo-2024-04-09": "2023-12",
"gpt-4-turbo-preview": "2023-12",
"gpt-4o": "2023-10",
"gpt-4o-2024-05-13": "2023-10",
"gpt-4o-2024-08-06": "2023-10",
"gpt-4o-2024-11-20": "2023-10",
"chatgpt-4o-latest": "2023-10",
"gpt-4o-mini": "2023-10",
"gpt-4o-mini-2024-07-18": "2023-10",
"gpt-4-vision-preview": "2023-04",
"o1-mini": "2023-10",
"o1-preview": "2023-10",
"gemini-pro": "2023-12",
"gemini-pro-vision": "2023-12",
+ "gemini-exp-1206": "2023-12",
+ "gemini-2.0-flash-thinking-exp-1219": "2023-12",
};
Committable suggestion skipped: line range outside the PR's diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move 1.5
together
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dogtiti, understood! We can group those β1.5β variants so that all gemini-1.5 entries appear together in the list. Once you confirm the exact desired ordering, weβll move them in the array accordingly. Let me know if this arrangement works for you or if you have a specific sequence in mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The KnowledgeCutOffDate
function really should be updated to include the new Gemini models. It seems like it hasn't been updated in quite a while, and gemini-pro
and gemini-pro-vision
appear to be deprecated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
app/constant.ts
Outdated
"gemini-1.5-flash", | ||
"gemini-1.5-flash-002", | ||
"gemini-1.5-flash-8b", | ||
"gemini-1.5-flash-exp-0827", | ||
"gemini-1.5-pro", | ||
"gemini-1.5-pro-002", | ||
"gemini-1.5-pro-exp-0827", | ||
"gemini-2.0-flash-thinking-exp-1219", | ||
"gemini-exp-1206", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move 1.5
together
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
β»οΈ Duplicate comments (1)
app/constant.ts (1)
334-336
:β οΈ Potential issueAdd knowledge cutoff dates for new experimental models
The new experimental models "gemini-exp-1206" and "gemini-2.0-flash-thinking-exp-1219" need to have their knowledge cutoff dates defined in the
KnowledgeCutOffDate
object.Apply this diff to add the knowledge cutoff dates:
"gemini-pro": "2023-12", "gemini-pro-vision": "2023-12", + "gemini-exp-1206": "2023-12", + "gemini-2.0-flash-thinking-exp-1219": "2023-12",
π§Ή Nitpick comments (2)
app/constant.ts (2)
322-324
: Group all gemini-1.5-pro variants togetherThe gemini-1.5-pro variants should be grouped together with "gemini-1.5-pro-latest" for better organization and readability.
Apply this diff to reorder the models:
"gemini-1.0-pro", // Deprecated on 2/15/2025 "gemini-1.5-pro-latest", + "gemini-1.5-pro", + "gemini-1.5-pro-002", + "gemini-1.5-pro-exp-0827", "gemini-1.5-flash-latest", "gemini-1.5-flash-8b-latest", - "gemini-1.5-pro", - "gemini-1.5-pro-002", - "gemini-1.5-pro-exp-0827",
327-331
: Group all gemini-1.5-flash variants togetherSimilar to the pro variants, the flash variants should be grouped together with their "latest" versions.
Apply this diff to reorder the models:
"gemini-1.5-flash-latest", "gemini-1.5-flash-8b-latest", + "gemini-1.5-flash", + "gemini-1.5-flash-8b", + "gemini-1.5-flash-002", + "gemini-1.5-flash-exp-0827", "learnlm-1.5-pro-experimental", - "gemini-1.5-flash", - "gemini-1.5-flash-8b", - "gemini-1.5-flash-002", - "gemini-1.5-flash-exp-0827",
"gemini-exp-1206", | ||
"gemini-2.0-flash-exp", | ||
"gemini-2.0-flash-thinking-exp-1219", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π‘ Codebase verification
Based on the search results, I can now generate the final response since we have enough context about the experimental models.
Documentation needed for experimental Gemini models
The experimental models "gemini-exp-1206" and "gemini-2.0-flash-thinking-exp-1219" are part of a series of experimental Gemini models in the codebase, but lack proper documentation about their capabilities and limitations. This could impact developers trying to use these models effectively.
- Add documentation for the following experimental models:
gemini-exp-1206
gemini-2.0-flash-thinking-exp-1219
- Other experimental variants:
gemini-exp-1114
,gemini-exp-1121
,gemini-2.0-flash-exp
The documentation should include:
- Model capabilities and use cases
- Any limitations or known issues
- Expected behavior differences from stable models
- Whether they support vision/multimodal features (since some Gemini models have vision capabilities)
π Analysis chain
Verify the experimental models are properly documented
The experimental models "gemini-exp-1206" and "gemini-2.0-flash-thinking-exp-1219" should have their capabilities and limitations documented.
Let's check if there's any documentation about these models:
Let me check if there are any comments or documentation near these model definitions.
Let me check if there's any documentation in other related files or configuration that might describe these experimental models.
Let me check if there are any comments or documentation in the codebase that might describe these experimental models or their capabilities.
π Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for documentation about the new experimental models
echo "Searching for documentation about new experimental models..."
rg -i "gemini-exp-1206|gemini-2.0-flash-thinking-exp-1219" --type md
# Check if there are any comments or documentation in TypeScript files
echo "Checking for inline documentation..."
rg -i "gemini-exp-1206|gemini-2.0-flash-thinking-exp-1219" --type ts -C 2
Length of output: 605
Script:
#!/bin/bash
# Check for any comments or documentation around these model definitions
echo "Checking for documentation context..."
rg -i "gemini-exp-1206|gemini-2.0-flash-thinking-exp-1219" --type ts -B 10 -A 2
# Check the file header or any surrounding documentation
echo "Checking the constant.ts file structure..."
head -n 50 app/constant.ts
Length of output: 2759
Script:
#!/bin/bash
# Check for any model-related documentation files
echo "Searching for model documentation files..."
fd -e md -e mdx -e txt model
# Check for any configuration or type definitions that might document these models
echo "Checking for model configurations..."
rg -i "model.*type|model.*interface|model.*config" --type ts -C 5
# Check for any comments containing "experimental" or "exp" near model definitions
echo "Checking for experimental model documentation..."
rg -i "experimental.*model|exp.*model" --type ts -C 5
Length of output: 113588
Script:
#!/bin/bash
# Search for any documentation about experimental features or models
echo "Searching for documentation about experimental features..."
rg -i "experimental|exp.*feature" --type md --type txt -C 5
# Check for any configuration or type definitions related to experimental models
echo "Checking for experimental model configurations..."
rg -i "gemini.*exp|experimental.*model" --type ts -C 5
# Check for any changelog or release notes
echo "Checking changelog or release notes..."
fd -e md -e txt -i changelog -i release
Length of output: 6043
π» εζ΄η±»ε | Change Type
π εζ΄θ―΄ζ | Description of Change
π θ‘₯ε δΏ‘ζ― | Additional Information
Summary by CodeRabbit