-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Privacy Manifest #5141
Add Privacy Manifest #5141
Conversation
Oh, my God. How do I fix this? "Some checks were not successful" |
If you want to test it out locally you can run |
Process completed with exit code 1.
I changed it from to s.resource_bundles = {"DGCharts" => ["Source/Charts/PrivacyInfo.xcprivacy"]} |
@pmairoldi Thank you. we caught the error. |
I didn't set a target for PrivacyInfo, so I added a setting. I don't know if this is necessary, but please review it. |
Thank you for accepting the PR. However, I think it is also necessary to make sure that this is applied properly as Apple demanded. And I think other users will have to check it out a lot. If this is wrong, an immediate response may also be needed.. When is the new release that includes this?? Once again, thank you for your care in a busy time. |
Issue Link π
#5131
Goals β½
add Privacy Manifest
Implementation Details π§
Testing Details π
I checked with CodeBase and thought 'DGCharts' had nothing to add to PrivacyInfo.
I think it will take a lot of people's opinions and tests to complete this.
Please check my PR and feel free to comment.
This resolves #5131