-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privacy Manfiest #5131
Comments
+1 |
Charts is on the list "SDKs that require a privacy manifest" provided by Apple |
+1 |
1 similar comment
+1 |
Any support/plan of Privacy Manifest? |
Yeah I have no issue with it. I don’t really work on anything swift right now so I have no idea what this entails. So if someone can create a pull request for this I’ll merge and create a new release. |
@pmairoldi Everyone. Is there anything in DGCharts(Charts) that corresponds to the document above?? Please feel free to share your opinions. (Please understand that I use a translator because my English is not good enough.) |
I created a PR (as mentioned above), please feel free to take a look.🙏 |
@danielgindi @pmairoldi |
I’ve quickly read up on the topic and there does not seem to be way to do so right now. I’ve found a similar issue Alamofire/Alamofire#3761 |
Yeah we can do both at once. Still unsure how to make the signature work. It has always been a problem with open source development. I have my own developer account but not one for this GitHub project. I’ll look around other projects to see what’s up there. |
@pmairoldi Is the signature required for Charts?
I don't know about Carthage, but for SPM and Cocoapods the sentence above sounds like the signature is not required. |
Nice catch! Thanks for the info |
I discovered a new while testing. Until now, most of the libraries that have added PrivacyInfo have not been marked in PrivacyReport. However, when an item is added to the 'Privacy Nutrition Label Types', the library name is displayed in the PrivacyReport. Many libraries have updated PrivacyInfo without adding anything from 'Privacy Nutrition Label Types'. Does anyone know about this? Is 'Privacy Nutrition Label Types' a must-have item? Or is it not necessary to display it in the privacy report? Please feel free to leave opinion. The 'PrivacyReport' I'm talking about can be downloaded as a PDF if you archive the app. https://developer.apple.com/videos/play/wwdc2023/10060/
(I used a translator.) |
Seems like this is for the consuming app no? It would be good to test if generating the report after integrating the library works properly. |
Looking for this change |
Hello, I think the time has come.. I think I'll have to apply it and see how it works. How are you going to proceed?? Even if it is applied, it is necessary to constantly check that Apple app reviews are passed properly for a while. I would appreciate it if you could share your plans or thoughts. |
Thank you for accepting the PR. However, I think it is also necessary to make sure that this is applied properly as Apple demanded. And I think other users will have to check it out a lot. If this is wrong, an immediate response may also be needed.. When is the new release that includes this?? Once again, thank you for your care in a busy time. |
What did you do?
Read Apple docs, which say:
Wasn't sure, so thought I'd ask (feature request?): does Charts use any APIs mentioned here? If so, are there plans to include a privacy manifest? I'm not 100% sure what that'd even look like, but this thread maybe has a little insight.
What did you expect to happen?
N/A
What happened instead?
N/A
DGCharts Environment
N/A
Demo Project
N/A
The text was updated successfully, but these errors were encountered: