Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api)!: remove plugin data #263

Merged
merged 2 commits into from
Aug 31, 2023
Merged

refactor(api)!: remove plugin data #263

merged 2 commits into from
Aug 31, 2023

Conversation

joshuasing
Copy link
Member

Summary
Remove ChameleonPluginData from the Chameleon API.
Fixes #257

Changes

  • Remove ChameleonPluginData interface and the default implementation
  • Remove plugin data from annotation-based generators
  • Remove plugin data from platform bootstraps and create methods
  • Bump version to 0.16.0-SNAPSHOT as this change breaks the API

Checklist

This pull request contains breaking changes.

BREAKING CHANGE: Removes plugin data from the API, breaking platform
bootstrap creation methods.
@joshuasing joshuasing added area: platform This involves updating, adding or removing a platform type: removal This removes a redundant or unused feature status: breaking This involves breaking an existing API area: annotations This involves updating, adding or removing code relating to annotation processing type: refactor This refactors existing code labels Aug 31, 2023
@joshuasing joshuasing self-assigned this Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #263 (ded415e) into main (047c10a) will increase coverage by 0.43%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #263      +/-   ##
============================================
+ Coverage     69.29%   69.73%   +0.43%     
+ Complexity      387      383       -4     
============================================
  Files            73       71       -2     
  Lines          1557     1520      -37     
  Branches         87       87              
============================================
- Hits           1079     1060      -19     
+ Misses          443      425      -18     
  Partials         35       35              
Files Changed Coverage Δ
...ain/java/dev/hypera/chameleon/ChameleonPlugin.java 100.00% <ø> (+16.66%) ⬆️
.../src/main/java/dev/hypera/chameleon/Chameleon.java 64.51% <100.00%> (-2.16%) ⬇️

@joshuasing joshuasing added this pull request to the merge queue Aug 31, 2023
Merged via the queue into main with commit 160b2a8 Aug 31, 2023
4 checks passed
@joshuasing joshuasing deleted the refactor/257 branch August 31, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: annotations This involves updating, adding or removing code relating to annotation processing area: platform This involves updating, adding or removing a platform status: breaking This involves breaking an existing API type: refactor This refactors existing code type: removal This removes a redundant or unused feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ChameleonPluginData
2 participants