Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ChameleonPluginData #257

Closed
2 tasks done
joshuasing opened this issue Aug 31, 2023 · 0 comments · Fixed by #263
Closed
2 tasks done

Remove ChameleonPluginData #257

joshuasing opened this issue Aug 31, 2023 · 0 comments · Fixed by #263
Labels
contributor: needs feedback Feedback is wanted before these changes are merged good first issue This issue is easy to resolve and is recommended for people who want to start contributing status: breaking This involves breaking an existing API type: removal This removes a redundant or unused feature

Comments

@joshuasing
Copy link
Member

Confirmation

  • I have checked for similar issues.
  • I using the latest version of Chameleon.

Describe the bug

Currently, Chameleon requires that plugins provide a ChameleonPluginData object during bootstrap creation.
This data is stored in Chameleon, however as Chameleon doesn't do anything with it, I don't see the reason for it being required, or existing in the first place.

I do not remember why this was originally introduced.

Expected behaviour

N/A

Reproduction steps

N/A

Exception

N/A

Environment

N/A

Additional information

No response
@joshuasing joshuasing added type: bug: unconfirmed An unconfirmed bug report status: triage This issue is awaiting review type: enhancement This is a feature request or a pull request that adds a feature type: removal This removes a redundant or unused feature status: breaking This involves breaking an existing API good first issue This issue is easy to resolve and is recommended for people who want to start contributing contributor: needs documentation These changes need to be documented before they can be merged contributor: needs feedback Feedback is wanted before these changes are merged contributor: wanted and removed type: bug: unconfirmed An unconfirmed bug report status: triage This issue is awaiting review type: enhancement This is a feature request or a pull request that adds a feature contributor: needs documentation These changes need to be documented before they can be merged contributor: wanted labels Aug 31, 2023
@joshuasing joshuasing mentioned this issue Aug 31, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributor: needs feedback Feedback is wanted before these changes are merged good first issue This issue is easy to resolve and is recommended for people who want to start contributing status: breaking This involves breaking an existing API type: removal This removes a redundant or unused feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(api)!: remove plugin data ChameleonFramework/Chameleon
1 participant
@joshuasing