Serve Lightclient related data via p2p #4365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate via p2p resp/req
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
reviewed
Aug 8, 2022
| requestBody: altair.LightClientUpdateByRangeRequest, | ||
| chain: IBeaconChain | ||
| ): AsyncIterable<altair.LightClientUpdate[]> { | ||
| yield await chain.lightClientServer.getUpdates(requestBody.startPeriod, requestBody.count); |
There was a problem hiding this comment.
should be wrapped in try/catch?
There was a problem hiding this comment.
I intentionally left out the try/catch since the spec did not explicitly say RESOURCE_UNAVAILABLE should be returned as it did in the other cases. I will look into this again, and if need be, make a PR to the spec.
There was a problem hiding this comment.
it makes sense to have RESOURCE_UNAVAILABLE response, may be the spec just missed it
There was a problem hiding this comment.
wrapped in try/catch and made a PR to update the spec here
There was a problem hiding this comment.
Alternative is to just return an empty result, or omit the periods that are unavailable, same as for beaconBlocksByRange / beaconBlocksByRoot.
…nt_optimistic_update available via the gossip domain
wemeetagain
reviewed
Oct 23, 2022
wemeetagain
reviewed
Oct 24, 2022
dapplion
reviewed
Oct 28, 2022
| private waitOneThirdOfSlot = async (slot: number): Promise<void> => { | ||
| const minPubTime = computeTimeAtSlot(this.config, slot, this.chain.genesisTime) + this.config.SECONDS_PER_SLOT / 3; | ||
| const waitTime = minPubTime - Date.now() / 1000; | ||
| await sleep(waitTime, this.signal); |
There was a problem hiding this comment.
sleep takes miliseconds, looks like it's passing seconds which would cause the sleep to wait 1000 times less than expected. Fixing on a commit locally, will push soon
|
I pushed some commits on top addressing some unaddressed comments to help expedite this. |
dapplion
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
LGMT, some comments for future work:
- Do not re-calculate
light_client_updates_by_rangereplies every time. Store in DB an SSZ compressed version of that data and just stream. This optimization should be done also for block by range - Consider moving lightclient class outside of Chain so it has access to network. It's now really something like the sync class
- Should the lightclient server validate messages before broadcasting?
- Emit logic from the lightclient server provider probably requires more validation
- Apply
is_better_updateconsistently in our lightclient data generator code, ref https://github.com/ethereum/consensus-specs/blob/be3c774069e16e89145660be511c1b183056017e/specs/altair/light-client/sync-protocol.md#is_better_update
dapplion
approved these changes
Oct 28, 2022
wemeetagain
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adds ability for a lodestar full node to serve light client related data via p2p. Implements the Altair Light Client -- Networking spec
Description
Confirmed the new gossip messages get's published. Also confirmed that changes did not break existing lightclient which uses the REST endpoint and SSE:
Using a minimalist libp2p node with gossip enabled (see here), the optimistic update message got picked up:
Consuming the light client related data will be implemented in #4618
Partially closes #3077