Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure LightClientUpdate returned by REST API do not exceed MAX_REQUEST_LIGHT_CLIENT_UPDATES #4633

Closed
dadepo opened this issue Oct 4, 2022 · 1 comment
Closed

Ensure LightClientUpdate returned by REST API do not exceed MAX_REQUEST_LIGHT_CLIENT_UPDATES #4633

dadepo opened this issue Oct 4, 2022 · 1 comment
Assignees
@dadepo
Labels
scope-light-clients All issues regarding light client development.

Comments

@dadepo
Copy link
Contributor

dadepo commented Oct 4, 2022

Is your feature request related to a problem? Please describe.

In the specification there is a requirement that results returned from /eth/v1/beacon/light_client/updates do not exceed MAX_REQUEST_LIGHT_CLIENT_UPDATES.

The response MUST NOT contain more than min(MAX_REQUEST_LIGHT_CLIENT_UPDATES, count) results.
@dadepo dadepo self-assigned this Oct 4, 2022
@dadepo dadepo added the scope-light-clients All issues regarding light client development. label Oct 4, 2022
@dadepo dadepo mentioned this issue Oct 4, 2022
Closed
@dadepo
Copy link
Contributor Author

dadepo commented Oct 31, 2022

Has been implemented as part of #4365

@dadepo dadepo closed this as completed Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dadepo dadepo

Labels
scope-light-clients All issues regarding light client development.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce the MAX_REQUEST_LIGHT_CLIENT_UPDATES limit ChainSafe/lodestar
1 participant
@dadepo