Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dot/network): replace sync.Map with map for stream manager #2366

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented Mar 10, 2022

Changes

Tests

All tests passing, no test added.

Issues

Primary Reviewer

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #2366 (8833e71) into development (e98c5ce) will increase coverage by 0.05%.
The diff coverage is 94.73%.

❗ Current head 8833e71 differs from pull request most recent head b510ed3. Consider uploading reports for the commit b510ed3 to get more accurate results

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2366      +/-   ##
===============================================
+ Coverage        57.99%   58.04%   +0.05%     
===============================================
  Files              214      214              
  Lines            28002    28021      +19     
===============================================
+ Hits             16239    16265      +26     
+ Misses           10121    10119       -2     
+ Partials          1642     1637       -5     
Flag Coverage Δ
unit-tests 58.04% <94.73%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dot/network/stream_manager.go 93.75% <94.73%> (+0.72%) ⬆️
dot/telemetry/mailer.go 56.71% <0.00%> (-4.48%) ⬇️
dot/network/connmgr.go 89.04% <0.00%> (-1.37%) ⬇️
lib/trie/database.go 47.54% <0.00%> (-0.86%) ⬇️
dot/network/service.go 57.30% <0.00%> (+0.46%) ⬆️
dot/network/host.go 65.37% <0.00%> (+1.06%) ⬆️
dot/network/message.go 68.99% <0.00%> (+2.62%) ⬆️
dot/network/block_announce.go 64.40% <0.00%> (+5.08%) ⬆️
dot/network/inbound.go 100.00% <0.00%> (+7.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fa346b...b510ed3. Read the comment docs.

dot/network/stream_manager.go Outdated Show resolved Hide resolved
Copy link
Member

@EclesioMeloJunior EclesioMeloJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, just a comment

dot/network/stream_manager.go Show resolved Hide resolved
@qdm12 qdm12 force-pushed the qdm12/syncmap-streammgr branch from 8833e71 to b510ed3 Compare March 15, 2022 14:55
@qdm12 qdm12 merged commit 9c30149 into development Mar 15, 2022
@qdm12 qdm12 deleted the qdm12/syncmap-streammgr branch March 15, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants