Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dot/network: log errors from stream.Close() #2376

Closed
qdm12 opened this issue Mar 15, 2022 · 0 comments · Fixed by #2779
Closed

dot/network: log errors from stream.Close() #2376

qdm12 opened this issue Mar 15, 2022 · 0 comments · Fixed by #2779

Comments

@qdm12
Copy link
Contributor

qdm12 commented Mar 15, 2022

Task summary

dot/network contains several _ = stream.Close().

We should log the errors returned at least at debug level.

Proposed by @EclesioMeloJunior here
@qdm12 qdm12 mentioned this issue Mar 15, 2022
Merged
axaysagathiya added a commit to axaysagathiya/gossamer that referenced this issue Aug 24, 2022
@axaysagathiya
log the errors from stream.Close()
354fc88 
Fixed ChainSafe#2376
@axaysagathiya axaysagathiya mentioned this issue Aug 24, 2022
Merged
EclesioMeloJunior pushed a commit that referenced this issue Aug 24, 2022
@axaysagathiya
chore(dot/network): log the errors from stream.Close() (#2779)
4ed3def 
* log the errors from stream.Close()

Fixed #2376

* replace %w with %s in logger.Warnf()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(dot/network): log the errors from stream.Close() axaysagathiya/gossamer
2 participants
@danforbes @qdm12