Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run intergration tests inside docker containers. #1149

Merged
merged 9 commits into from
Nov 2, 2020
Merged

Run intergration tests inside docker containers. #1149

merged 9 commits into from
Nov 2, 2020

Conversation

arijitAD
Copy link
Contributor

@arijitAD arijitAD commented Oct 28, 2020 •
edited
Loading

Changes

  • Update Travis config to run integration test in Docker container.

Checklist

  • I have read CODE_OF_CONDUCT and CONTRIBUTING
  • I have provided as much information as possible and necessary
  • I have reviewed my own pull request before requesting a review
  • All integration tests and required coverage checks are passing

Issues

edwardmack
edwardmack approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@edwardmack edwardmack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, LGTM.

@noot
Copy link
Contributor

noot commented Oct 28, 2020

it looks like there is an issue with running the docker tests:

$ docker run -it --entrypoint="make" chainsafe/gossamer:latest it-stable
Unable to find image 'chainsafe/gossamer:latest' locally
docker: Error response from daemon: pull access denied for chainsafe/gossamer, repository does not exist or may require 'docker login'.

@arijitAD arijitAD merged commit 26fb75f into development Nov 2, 2020
@arijitAD arijitAD deleted the arijitAD/dockerize-intergation-test branch November 2, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noot noot noot approved these changes

@edwardmack edwardmack edwardmack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arijitAD @noot @edwardmack