Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix skipped tests #1026

Closed
2 of 16 tasks
noot opened this issue Jul 24, 2020 · 3 comments
Closed
2 of 16 tasks

fix skipped tests #1026

noot opened this issue Jul 24, 2020 · 3 comments
Assignees
@timwu20
Labels
Epic Issue used to track development status of a complex feature, aggregates several issues

Comments

@noot
Copy link
Contributor

noot commented Jul 24, 2020 •
edited
Loading

Expected Behavior

  • tests should pass on CI if they pass locally
  • add back skipped tests

Current Behavior

some tests fail randomly on CI: (add more as needed)

  • network TestGossip, TestStreamManager_KeepStream, TestPersistentPeers, TestRemovePeer, TestSetReservedPeer
  • messages TestService_HandleTransactionMessage
  • author TestAuthorModule_SubmitExtrinsic
  • author TestAuthorModule_SubmitExtrinsic_invalid
  • author TestAuthorModule_SubmitExtrinsic_InQueue
  • rpc TestStateModule_GetMetadata
  • build TestBuildBlock_failing
  • extrinsics TestAuthoritiesChangeExt_Encode
  • exports TestInstance_ExecuteBlock_PolkadotRuntime_PolkadotBlock1, TestInstance_Version_NodeRuntime
  • imports Test_ext_storage_clear_prefix_version_1
  • wasmer TestInstance_ExecuteBlock_GossamerRuntime, TestInstance_ApplyExtrinsic_GossamerRuntime, Test_ext_offline_index_set_version_1
  • grandpa TestGrandpa_NonAuthority, TestStress_Grandpa_ThreeAuthorities, TestStress_Grandpa_SixAuthorities, TestGrandpa_DifferentChains
  • stress tests TestSync_SingleSyncingNode, TestSync_ManyProducers, TestSync_Restart, TestSync_MultipleEpoch

Possible Solution

  • this may be due to some underlying randomness
  • for integration tests, this is probably due to timing issues

Checklist

  • I have read CODE_OF_CONDUCT and CONTRIBUTING
  • I have provided as much information as possible and necessary
  • I am planning to submit a pull request to fix this issue myself
@arijitAD arijitAD self-assigned this Oct 27, 2020
This was referenced Oct 28, 2020
Merged
Merged
@dutterbutter dutterbutter changed the title fix tests that fail on CI fix skipped tests Jan 8, 2021
@noot noot mentioned this issue Jan 14, 2021
Merged
4 tasks
@dutterbutter dutterbutter added p1 and removed p2 labels Jun 23, 2021
@timwu20 timwu20 mentioned this issue Jun 30, 2021
Merged
@danforbes danforbes added the Epic Issue used to track development status of a complex feature, aggregates several issues label Sep 20, 2021
@noot noot mentioned this issue Nov 10, 2021
Merged
@kishansagathiya
Copy link
Contributor

Some more context on TestGossip here #1026

@kishansagathiya kishansagathiya mentioned this issue Nov 30, 2021
Closed
@kishansagathiya
Copy link
Contributor

I have fixed some of the skipped tests (the ones related to dot/peerset and dot/network) in dht pr #2059

@jimjbrettj
Copy link
Contributor

We have rewritten many tests in our package making this issue stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timwu20 timwu20

Labels
Epic Issue used to track development status of a complex feature, aggregates several issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@timwu20 @danforbes @arijitAD @kishansagathiya @dutterbutter @noot @jimjbrettj