Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point Cloud Attenuation in ModelExperimental #9998

Merged
merged 24 commits into from
Jan 12, 2022
Merged

Point Cloud Attenuation in ModelExperimental #9998

merged 24 commits into from
Jan 12, 2022

Conversation

ptrgags
Copy link
Contributor

@ptrgags ptrgags commented Jan 7, 2022

In #9978, I added a transcoder from .pnts -> ModelExperimental. However, there are more point-cloud specific features to add, point cloud attenuation being the main one that's missing.

Point Cloud Shading Sandcastle + Model Experimental -- mostly working.

The nice thing is eye dome lighting seems to be working for free.

To Do:

@cesium-concierge
Copy link

Thanks for the pull request @ptrgags!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

Copy link
Contributor Author

@ptrgags ptrgags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that toggling attenuation should trigger a rebuild of the pipeline. I have some ideas on how to refactor the pipeline creation to do this.

@ptrgags
Copy link
Contributor Author

ptrgags commented Jan 11, 2022

Here's another local sandcastle that uses point cloud attenuation on an individual ModelExperimental:

glTF with point cloud shading with custom shader with both
image image image image

The custom shader does not have a custom vertex shader, so the point cloud attenuation's point size does get used, while the custom shader sets the color.

@lilleyse this is ready for review now

@ptrgags ptrgags marked this pull request as ready for review January 11, 2022 20:27
@ptrgags ptrgags requested a review from lilleyse January 11, 2022 20:28
@ptrgags
Copy link
Contributor Author

ptrgags commented Jan 11, 2022

Also I opened #10005 about eye dome lighting for individual models (right now only 3D Tiles EDL works)

Copy link
Contributor

@lilleyse lilleyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested a few sandcastles before/after and the results look the same.

@ptrgags
Copy link
Contributor Author

ptrgags commented Jan 12, 2022

@lilleyse updated!

@lilleyse
Copy link
Contributor

👍

@lilleyse lilleyse merged commit ee4f648 into main Jan 12, 2022
@lilleyse lilleyse deleted the attenuation branch January 12, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants