-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds dynamic model/node transformations to ModelExperimentalNode #9989
Conversation
Thanks for the pull request @sanjeetsuhag!
Reviewers, don't forget to make sure that:
|
this.sceneGraph = options.sceneGraph; | ||
|
||
/** | ||
* The indices of the children of this node in the runtime nodes array of the scene graph. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will users expect the exact same indices as in the glTF? Because the runtimeNodes
array is generated from a post-order depth-first traversal of the scene graph, a node's glTF ID will not necessarily be a match to its index in the runtimeNodes
array.
@ptrgags This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanjeetsuhag just a few minor comments
Looks good to me, @lilleyse do you want to take a look before I merge? |
@ptrgags feel free to merge |
Thanks @sanjeetsuhag! |
This PR adds support for dynamically changing node transforms in
ModelExperimental
. It also adds the ability to traverse the scene graph ofModelExperimentaNode
objects.Architecture
model.modelMatrix
updatenode.transform
updateTo-Do
modelMatrix
Testing