Handle vec3 colors correctly in custom shaders #9964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @ptrgags!
Reviewers, don't forget to make sure that:
|
|
@lilleyse synced with main |
ptrgags
force-pushed
the
color-vec3-custom-shaders
branch
from
d57d1a1 to
d311ce2
Compare
|
@lilleyse reset the branch to untangle the confusing git history |
|
Thanks @ptrgags |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge this until #9960 is merged first.
This continues the saga of #9955 and #9957, looks like I missed a spot in
CustomShaderPipelineStage-- looks like I wasn't usingModelExperimentalUtility.getAttributeInfowhich computes the correct GLSL type ofvec4in this case.@lilleyse could you review?
Use this local Sandcastle -- last item in the dropdown. I updated the shader to use
fsInput.attributes.color_0, now it doesn't crash like in previous branches.