Fix quantized vec3 colors in ModelExperimental #9957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @ptrgags!
Reviewers, don't forget to make sure that:
|
sanjeetsuhag
approved these changes
Dec 3, 2021
There was a problem hiding this comment.
Changes look good. Tested with this local Sandcastle and the model is loading, and the VEC3 is correctly being promoted to VEC4 in the shader.
Thanks @ptrgags!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9814
(Note: don't use the model from the original issue, it still won't load due to #9956 which is a separate issue)
#9955 fixed vec3 colors in
ModelExperimental, but a few more steps had to be done for this to work with quantized attributes (as even the offset/stepSize uniforms need to be promoted tovec4@sanjeetsuhag could you review?