Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime Errors when a tileset contains unsupported extensions #9580

Conversation

srothst1
Copy link
Contributor

@srothst1 srothst1 commented Jun 1, 2021

Fixes Issue #9552
There is currently no _extensionsRequired property in Cesium3DTileset. This pull request uses the _extensions property.

Should we add _extensionsRequired?

cc @ptrgags @lilleyse

@cesium-concierge
Copy link

Thanks for the pull request @srothst1!

  • ❌ Missing CLA.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@srothst1 srothst1 changed the title Console warnings when a tileset contains unsupported extensions 9952 Warnings when a tileset contains unsupported extensions Jun 1, 2021
@shehzan10 shehzan10 changed the title Warnings when a tileset contains unsupported extensions Runtime Errors when a tileset contains unsupported extensions Jun 1, 2021
@srothst1 srothst1 merged commit ce84719 into master Jun 1, 2021
@srothst1 srothst1 deleted the Console-Warnings-When-a-Tileset-Contains-Unsupported-Extensions-9952 branch June 1, 2021 21:30
@lilleyse
Copy link
Contributor

lilleyse commented Jun 1, 2021

@srothst1 did you mean to merge this? Can you open a PR to revert this change? Then after that PR is merged you can re-open this PR and @ptrgags should have a chance to review it properly.

CC @shehzan10

@srothst1 srothst1 restored the Console-Warnings-When-a-Tileset-Contains-Unsupported-Extensions-9952 branch June 2, 2021 13:06
@srothst1 srothst1 deleted the Console-Warnings-When-a-Tileset-Contains-Unsupported-Extensions-9952 branch June 2, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants