Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add console warnings when a tileset contains unsupported extensions #9552

Closed
ptrgags opened this issue May 20, 2021 · 3 comments · Fixed by #9586
Closed

Add console warnings when a tileset contains unsupported extensions #9552

ptrgags opened this issue May 20, 2021 · 3 comments · Fixed by #9586

Comments

@ptrgags
Copy link
Contributor

ptrgags commented May 20, 2021

If a tileset specifies an extension in extensionsRequired, that is not supported, we should log at least a warning in the console.

  • We'll need to put together a list of supported extensions:
    • 3DTILES_metadata
    • 3DTILES_implicit_tiling
    • 3DTILES_content_gltf
    • 3DTILES_multiple_contents
    • 3DTILES_bounding_volume_S2
    • 3DTILES_batch_table_hierarchy
    • 3DTILES_draco_point_compression

Some things to consider:

  • See how ModelUtility.js handles glTF extensionsRequired and do something similar
  • Also, we probably would need to update Model to include EXT_feature_metadata
@lilleyse
Copy link
Contributor

lilleyse commented Jun 1, 2021

Couple more notes for this:

@mramato
Copy link
Contributor

mramato commented Jun 1, 2021

Why would these be warnings instead of errors? Does a user have any way to handle this themselves so they could choose to not load the tileset or show a message to their users?

@lilleyse
Copy link
Contributor

lilleyse commented Jun 1, 2021

Hm, I suppose it should be a runtime error instead like what ModelUtility does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants