Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate loadCRN and loadKTX #9478

Merged
merged 5 commits into from
Apr 9, 2021
Merged

Deprecate loadCRN and loadKTX #9478

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9fc1b0f
deprecation warnings in loadCRN and loadKTX
ebogo1 Apr 9, 2021
e2ad7df
update CHANGES.md
ebogo1 Apr 9, 2021
37130dd
change deprecation wording
ebogo1 Apr 9, 2021
c73c5e2
Update CHANGES.md
lilleyse Apr 9, 2021
fadf3e2
Update CHANGES.md
lilleyse Apr 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Change Log

### 1.81 - 2021-05-01

##### Deprecated :hourglass_flowing_sand:

- `loadCRN` was deprecated and will be removed in Cesium 1.82. It will be replaced with support for KTX2.[9478](https://github.com/CesiumGS/cesium/pull/9478)
ebogo1 marked this conversation as resolved.
Show resolved Hide resolved
- `loadKTX` was deprecated and will be removed in Cesium 1.82. It will be replaced with support for KTX2. [9478](https://github.com/CesiumGS/cesium/pull/9478)
ebogo1 marked this conversation as resolved.
Show resolved Hide resolved

### 1.80 - 2021-04-01

##### Additions :tada:
Expand Down
6 changes: 6 additions & 0 deletions Source/Core/loadCRN.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import defined from "./defined.js";
import DeveloperError from "./DeveloperError.js";
import Resource from "./Resource.js";
import TaskProcessor from "./TaskProcessor.js";
import deprecationWarning from "./deprecationWarning.js";

var transcodeTaskProcessor = new TaskProcessor("transcodeCRNToDXT");

Expand Down Expand Up @@ -36,8 +37,13 @@ var transcodeTaskProcessor = new TaskProcessor("transcodeCRNToDXT");
* @see {@link https://github.com/BinomialLLC/crunch|crunch DXTc texture compression and transcoding library}
* @see {@link http://www.w3.org/TR/cors/|Cross-Origin Resource Sharing}
* @see {@link http://wiki.commonjs.org/wiki/Promises/A|CommonJS Promises/A}
* @deprecated This function has been deprecated and will be removed in Cesium 1.82.
*/
function loadCRN(resourceOrUrlOrBuffer) {
deprecationWarning(
"loadCRN",
"loadCRN is deprecated and will be removed in Cesium 1.82."
ebogo1 marked this conversation as resolved.
Show resolved Hide resolved
);
//>>includeStart('debug', pragmas.debug);
if (!defined(resourceOrUrlOrBuffer)) {
throw new DeveloperError("resourceOrUrlOrBuffer is required.");
Expand Down
6 changes: 6 additions & 0 deletions Source/Core/loadKTX.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import PixelFormat from "./PixelFormat.js";
import Resource from "./Resource.js";
import RuntimeError from "./RuntimeError.js";
import WebGLConstants from "./WebGLConstants.js";
import deprecationWarning from "./deprecationWarning.js";

/**
* Asynchronously loads and parses the given URL to a KTX file or parses the raw binary data of a KTX file.
Expand Down Expand Up @@ -57,8 +58,13 @@ import WebGLConstants from "./WebGLConstants.js";
* @see {@link https://www.khronos.org/opengles/sdk/tools/KTX/file_format_spec/|KTX file format}
* @see {@link http://www.w3.org/TR/cors/|Cross-Origin Resource Sharing}
* @see {@link http://wiki.commonjs.org/wiki/Promises/A|CommonJS Promises/A}
* @deprecated This function has been deprecated and will be removed in Cesium 1.82.
*/
function loadKTX(resourceOrUrlOrBuffer) {
deprecationWarning(
"loadKTX",
"loadKTX is deprecated and will be removed in Cesium 1.82."
ebogo1 marked this conversation as resolved.
Show resolved Hide resolved
);
//>>includeStart('debug', pragmas.debug);
Check.defined("resourceOrUrlOrBuffer", resourceOrUrlOrBuffer);
//>>includeEnd('debug');
Expand Down