-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate loadCRN and loadKTX #9478
Conversation
Thanks for the pull request @ebogo1!
Reviewers, don't forget to make sure that:
|
Just noting here that once we remove
Both of these use KTX textures |
I pushed some tweaks to |
It's in both the |
One option is to roll back the deprecation warnings and add them as part of the KTX2 PR. If delaying that PR by adding back loadKTX/CRN isn't worth it, maybe we can just remove the "compressed image" option from Both Sandcastles are using KTX 2.0 in the new PR. |
I think the main reason we wanted to deprecate was because no one as far as we know is actually using old KTX and it was easier to make a clean break. If the Sandcastle examples are just updated to use KTX2 in your PR, then it would be silly to remove them and then re-add them.. Both Sandcastles are specific to compressed textures, I believe, so we can't really make them use something else (and it's probably not worth it). |
Okay, since @lilleyse is MIA, I'm going to just proceed as things currently are. We want to drop CRN/KTX asap so getting the notice in now is probably the best choice. |
I think it's fine to proceed. There's no way to remove KTX1 support from the Image-Based Lighting sandcastle without breaking it before KTX2 is in. The other approach could have been to add KTX2 and in the same PR have an immediate breaking change for CRN/KTX1, but that doesn't give as much warning. |
This deprecates
loadCRN
andloadKTX
as we will move to support KTX2 in Cesium 1.82.