Added throttle option to TerrainData.createMesh #9313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d a throttle option to TerrainData.createMesh, and using options object for TerrainData.createMesh
|
Thanks for the pull request @IanLilleyT!
Reviewers, don't forget to make sure that:
|
IanLilleyT
commented
Jan 11, 2021
CHANGES.md
Outdated
|
|
||
| ##### Additions :tada: | ||
|
|
||
| - Added `Cartesian2.cross`. [#9305](https://github.com/CesiumGS/cesium/pull/9305) |
There was a problem hiding this comment.
Leftover from #9305
|
Thanks again for your contribution @IanLilleyT! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
|
Looks good. Thanks @IanLilleyT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR originates from #9286 (comment). It adds a
throttleoption toTerrainData.createMeshwhich says whether it should limit the number of asynchronous mesh creations. Note thatcreateMeshnow takes an options object instead of separate arguments.For rendering purposes, throttling is enabled so that only the most relevant terrain tiles are processed, letting it quickly adapt to camera movements.
For
sampleTerrain/sampleTerrainMostDetailed, throttling is disabled so that all heights are sampled at once. This ability is needed by #9286 which callscreateMeshwhen aTerrainDatacan't be interpolated from its raw buffer. Before, if the sample positions spanned a large number of tiles, many of the heights would be undefined because the system couldn't spawn a worker for every tile.This PR also sets
TaskProcessor.maximumActiveTasksconstructor option to infinity by default.