Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cartesian2.cross #9305

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Add Cartesian2.cross #9305

merged 2 commits into from
Jan 7, 2021

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Jan 5, 2021

No description provided.

@cesium-concierge
Copy link

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@IanLilleyT
Copy link
Contributor

Code looks fine but if we use the name "cross product" there might need to be some explanation in the description like Computes the magnitude of the cross product that would result from implicitly setting the Z coordinate of the input vectors to 0. More elegant description welcome.

@hpinkos
Copy link
Contributor Author

hpinkos commented Jan 7, 2021

Works for me, thanks @IanLilleyT! Updated

@IanLilleyT IanLilleyT merged commit 13a0d7d into master Jan 7, 2021
@IanLilleyT IanLilleyT deleted the cartesian2-cross branch January 7, 2021 19:09
@IanLilleyT
Copy link
Contributor

Looks good, thanks @hpinkos !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants