Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSDoc/TS of writeTextToCanvas #9219

Merged
merged 2 commits into from
Nov 1, 2020
Merged

Fix JSDoc/TS of writeTextToCanvas #9219

merged 2 commits into from
Nov 1, 2020

Conversation

OmarShehata
Copy link
Contributor

This moves the changes over from #9196 since I didn't seem to have push access to that branch in the fork.

This fixes the return type of writeTextToCanvas which can return undefined, and updates CHANGES.md and adds a test in index.ts.

@cesium-concierge
Copy link

Thanks for the pull request @OmarShehata!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@OmarShehata OmarShehata mentioned this pull request Nov 1, 2020
Closed
@OmarShehata OmarShehata merged commit 97463fd into master Nov 1, 2020
@OmarShehata OmarShehata deleted the pr/9196 branch November 1, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OmarShehata @cesium-concierge @zoran995