Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSDoc/TS of writeTextToCanvas #9196

Closed
wants to merge 1 commit into from
Closed

Conversation

zoran995
Copy link
Contributor

writeTextToCanvas can also return undefined

@cesium-concierge
Copy link

Thanks for the pull request @zoran995!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@OmarShehata
Copy link
Contributor

Thanks @zoran995! I don't seem to have push access to your fork/branch, I opened #9219 to update CHANGES.md and add a test.

@OmarShehata OmarShehata closed this Nov 1, 2020
@zoran995 zoran995 deleted the patch-1 branch November 1, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants