Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to CLA folder for maintainers #9148

Merged
merged 3 commits into from
Nov 2, 2020
Merged

Add link to CLA folder for maintainers #9148

merged 3 commits into from
Nov 2, 2020

Conversation

OmarShehata
Copy link
Contributor

The linked Google Drive folder is not a publicly accessible link, but is visible to members of the Cesium team. It's useful to have this link handy in cases when you need to manually check a CLA, like if the bot fails: #9147 (comment).

@cesium-concierge
Copy link

Thanks for the pull request @OmarShehata!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@hpinkos
Copy link
Contributor

hpinkos commented Sep 11, 2020

@OmarShehata I don't think this is the right place for that. Maybe put a README.md in https://github.com/CesiumGS/cesium/tree/master/Documentation/Contributors/CLAs?

@OmarShehata
Copy link
Contributor Author

Are people going to find it there? I'm not sure how you'd end up there, that folder isn't really linked to from anywhere else. Maybe the best place is in concierge's comment itself, so it could be:

❌ Missing CLA.

Since that's often when people actually need it.

@OmarShehata
Copy link
Contributor Author

@hpinkos I've moved it to a README under the CLAs folder as you suggested, and added a note for concierge when the CLA check fails or a CLA is not found since that is when maintainers will need to manually check the Google drive link.

@OmarShehata
Copy link
Contributor Author

Thanks @hpinkos , should be ready.

@cesium-concierge
Copy link

Thanks again for your contribution @OmarShehata!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@OmarShehata
Copy link
Contributor Author

@hpinkos can you merge or let me know if you have any other feedback?

@hpinkos hpinkos merged commit 3d665a4 into master Nov 2, 2020
@hpinkos hpinkos deleted the OmarShehata-patch-1 branch November 2, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants