-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to CLA folder for maintainers #9148
Conversation
Thanks for the pull request @OmarShehata!
Reviewers, don't forget to make sure that:
|
@OmarShehata I don't think this is the right place for that. Maybe put a README.md in https://github.com/CesiumGS/cesium/tree/master/Documentation/Contributors/CLAs? |
Are people going to find it there? I'm not sure how you'd end up there, that folder isn't really linked to from anywhere else. Maybe the best place is in concierge's comment itself, so it could be:
Since that's often when people actually need it. |
@hpinkos I've moved it to a README under the CLAs folder as you suggested, and added a note for concierge when the CLA check fails or a CLA is not found since that is when maintainers will need to manually check the Google drive link. |
Thanks @hpinkos , should be ready. |
Thanks again for your contribution @OmarShehata! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
@hpinkos can you merge or let me know if you have any other feedback? |
The linked Google Drive folder is not a publicly accessible link, but is visible to members of the Cesium team. It's useful to have this link handy in cases when you need to manually check a CLA, like if the bot fails: #9147 (comment).